* [dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ?
@ 2015-11-22 23:53 Matthew Hall
2015-11-23 0:20 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Hall @ 2015-11-22 23:53 UTC (permalink / raw)
To: dev
I was reading through the deprecations in rte_eth_stats to see if I could fix
the pktgen. Of course many fields were marked with __rte_deprecated .
However I found this one field which said deprecated in its comment, but it
lacked __rte_deprecated .
Is the comment wrong, or is the field definition wrong, or did I miss
something?
uint64_t imcasts;
/**< Deprecated; Total number of multicast received packets. */
Matthew.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ?
2015-11-22 23:53 [dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ? Matthew Hall
@ 2015-11-23 0:20 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-11-23 0:20 UTC (permalink / raw)
To: Matthew Hall; +Cc: dev
2015-11-22 18:53, Matthew Hall:
> I was reading through the deprecations in rte_eth_stats to see if I could fix
> the pktgen. Of course many fields were marked with __rte_deprecated .
>
> However I found this one field which said deprecated in its comment, but it
> lacked __rte_deprecated .
When setting the __rte_deprecated attribute, Stephen wanted to keep imcasts:
http://dpdk.org/dev/patchwork/patch/8732/
> Is the comment wrong, or is the field definition wrong, or did I miss
> something?
We have to decide if we really want to deprecate it.
I think we should set the deprecated attribute and it seems agreed.
> uint64_t imcasts;
> /**< Deprecated; Total number of multicast received packets. */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-23 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-22 23:53 [dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ? Matthew Hall
2015-11-23 0:20 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).