From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id BDF598D38 for ; Mon, 23 Nov 2015 01:22:05 +0100 (CET) Received: by wmww144 with SMTP id w144so84898115wmw.0 for ; Sun, 22 Nov 2015 16:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=qc5m53YUiCQTSH2WAVfqQw5Z+FjVO0psvrah0Sv+/2A=; b=GzYQQ9Ev32S+zuJ944n03tBq0UdJLYeW6Y5+CiIWQ6ZnrH51hiBmMpWxHaa1izyh5U N95JHiK8EpPFFJfGc5waFHJbFigCe1444NV0ne1E2sy0TiHCe5+or8m7hWE5xYkBtmSO WsSkDm6ePzxD0A5Fnq+oSiqcYONIHl45IsTfi3fr0XqCr/g3bIgZifJhvASJCa3X1t3d 29wjD+gzyvVccWFBrvnyuMpvXdwVmflnVILBdjFncR9xzVbjjRrAOTCCcKDuNq2ynx6V X8Yze9oIAScV/NXtuIPvMoDWwH2mpS0SEpX4z7/+aOgxWzSZ6UnwTYaR3uLYmmkWuIKp h/7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qc5m53YUiCQTSH2WAVfqQw5Z+FjVO0psvrah0Sv+/2A=; b=ZtnNiRDQzoZuXvzs9MSKo6Tu5lEILUrl3D6dpBNtTeWl5Y37hHB13bIr4KxWbA2nAI zSVyMvjo3RjLSX0EzbxPf8ip60+6zDl8CqLPXYr46NR4Pb4TkOFlOuFJW5Cyo9PyfFDl IWlPxaa2ryGrJ8nnLzKZx/HKOtP0D7EnKgVJeqgHUwFMtr1scvDkivqURStxAD2JPukd +3ozr9qWUrHwqhYbCzt0/PfQbd/tadUzStnfOyukiVXKKk90MubZfWyyZwfw6+IyTXvR 1zc3SjSLpPvm/uKFu1kxjNnkL6sJwcPEpSAXH7iXn25ehofIHlo3hE4EgCdtTAMSklsi RoTQ== X-Gm-Message-State: ALoCoQk/4KeYmEY33YBPz2LfySb0BI/8cKRq66l747UkEAAqjIp4mVBhOaj7p3ExR5DmgqSy3Ak0 X-Received: by 10.28.107.26 with SMTP id g26mr13632476wmc.34.1448238124578; Sun, 22 Nov 2015 16:22:04 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id cl5sm10639856wjc.29.2015.11.22.16.22.03 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 22 Nov 2015 16:22:03 -0800 (PST) From: Thomas Monjalon To: Matthew Hall Date: Mon, 23 Nov 2015 01:20:48 +0100 Message-ID: <2992545.C0cUSYYlcR@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151122235342.GA28210@mhcomputing.net> References: <20151122235342.GA28210@mhcomputing.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2015 00:22:05 -0000 2015-11-22 18:53, Matthew Hall: > I was reading through the deprecations in rte_eth_stats to see if I could fix > the pktgen. Of course many fields were marked with __rte_deprecated . > > However I found this one field which said deprecated in its comment, but it > lacked __rte_deprecated . When setting the __rte_deprecated attribute, Stephen wanted to keep imcasts: http://dpdk.org/dev/patchwork/patch/8732/ > Is the comment wrong, or is the field definition wrong, or did I miss > something? We have to decide if we really want to deprecate it. I think we should set the deprecated attribute and it seems agreed. > uint64_t imcasts; > /**< Deprecated; Total number of multicast received packets. */