From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1150BA04B5; Fri, 6 Nov 2020 18:12:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01AA41D9E; Fri, 6 Nov 2020 18:12:01 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D29D100C for ; Fri, 6 Nov 2020 18:11:58 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EA6C95C0199; Fri, 6 Nov 2020 12:11:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 06 Nov 2020 12:11:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= DNrxLFYj0Zz3TTxETAgTgnfg4WD+OrR8906zwbvwMyg=; b=TNvoCBWGrQdX5eRs NXX+90oIhKcq4kXq9MtX5DvWQ+UvUbW3NWMAkAFzb/OI+XqtQlxfK4AKJ/2dUEtY ien7ozl1dMX0fNiq4HohlovDXv3O3QB76l0wnJ+wgwJodrFDCh39M6dFchaVE9Cj k8kiYaKqDngWt926ac+ITHPRkLUyApxXit18+0OYqKsJnp5G3WGu0MQOKk5HT8FH 9b2OSgXudpd92A4TwFz9JpzU7l1WuOot/laTO16oRu7aoIsf4xG7015nYxzoG69Y y+O9ig2bbeS5GN37Ym/2mxMsPvm14XD4J9HvsNIHKr9AqdUkuKEu0ZbV9WMolVYF 5iNvYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DNrxLFYj0Zz3TTxETAgTgnfg4WD+OrR8906zwbvwM yg=; b=idu1SdJF10N3EFQzKs59I8sDcaNntFgvqlrLA9RJ2NCgjsug/i+vGl1ga QbZYdCf4Mz3vsm8ulvHr1U2aIIofZl0yT7a2XJpH2rj+gYjv4ilCYB/AeKaLppVE 5YnpyXnrRofHQVl9k1a2nKke63Os0CxN3oNDxkCmg/RpOVRzPNg9Xsd/K8GWUnPh V2vwnQMY8p+I9FBDrnixi5xWw0ujOc1rnfBL1lR1oPXezkfhizRWClRkH3Z/qvdx GtfDCy9Y0ohk2/bs4VLVXLPYM+tzmDGTRvcO6723d496Dr03UoujHZXYRBHeTQ5b MmJ/xzYDjoga+574AIAquqZZR3CGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtledguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B5023060057; Fri, 6 Nov 2020 12:11:55 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 06 Nov 2020 18:11:54 +0100 Message-ID: <2994887.5P9aRgmb0G@thomas> In-Reply-To: <20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com> References: <20201105110728.220957-1-bruce.richardson@intel.com> <20201106165611.232288-1-thomas@monjalon.net> <20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/1] devtools: test 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/11/2020 18:01, Bruce Richardson: > On Fri, Nov 06, 2020 at 05:56:10PM +0100, Thomas Monjalon wrote: > > From: Bruce Richardson > > > > It's reasonably common for patches to have issues when built on 32-bits, so > > to prevent this, we can add a 32-bit build (if supported) to the > > "test-meson-builds.sh" script. The tricky bit is using a valid > > PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that > > should point to in order to get a successful build. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Thomas Monjalon > > --- > > v3: unset override > > move and rename override > > split command in check_cc_flags > > use check_cc_flags for x86 default build > > v2: added separate flag checking function > > added override of the DPDK_TARGET value > > added /usr/lib32 as possible 32-bit libdir > > --- > > devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++--- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > > index a87de635a2..ac76c2184b 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS > > default_cflags=$CFLAGS > > default_ldflags=$LDFLAGS > > > > +check_cc_flags () # ... > > +{ > > + echo 'int main(void) { return 0; }' | > > + cc $@ -x c - -o /dev/null 2> /dev/null > > Minor nit, as a continuation of the previous line, I think this should be > further indented. In general I keep piped commands at the same level. This is a matter of taste, but I can see other piped commands indented in this file, so I will indent this one as well. > Otherwise all looks good to me. Thanks for the updated changes. Then I will merge it with above change. I guess we won't get more reviews.