DPDK patches and discussions
 help / color / mirror / Atom feed
From: "lihuisong (C)" <lihuisong@huawei.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,
	huangdaode <huangdaode@huawei.com>
Subject: Question about flow_type_rss_offloads in rte_eth_dev_info
Date: Fri, 22 Apr 2022 11:55:59 +0800	[thread overview]
Message-ID: <2994c7eb-7ef4-d82d-0a49-ab3c9c8b675e@huawei.com> (raw)

Hi, all.

The RTE_ETH_FLOW_XXX macros, are used to display supported flow types 
for PMD
based on the rte_eth_dev_info.flow_type_rss_offloads in the 
port_infos_display() of
testpmd.

And PMD assigns RSS offload capability bit, like RTE_ETH_RSS_XXX, to 
this field.
The usage of RTE_ETH_RSS_XXX macros are described as follows in:
/*
  * Below macros are defined for RSS offload types, they can be used to
  * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types.
  */
#define RTE_ETH_RSS_IPV4               RTE_BIT64(2)

But RTE_ETH_FLOW_MAX is 24, and the number of RTE_ETH_FLOW_XXX micro far 
less than
the number of RTE_ETH_RSS_XXX. If PMD sets RSS offload capability bit 
out range of
RTE_ETH_FLOW_XXX, like RTE_ETH_RSS_L3_SRC_ONLY, to this field, testpmd 
will display
"user defined 63" when run 'show port info 0'. This is a problem that I 
have now.

On the other hand, rx_adv_conf.rte_eth_rss_conf.rss_hf from App must be 
within the
rte_eth_dev_info.flow_type_rss_offloads in dev_configure.

To sum up, I'm a little confused right now.
How should PMD populate the field "flow_type_rss_offloads" in struct 
rte_eth_dev_info?

             reply	other threads:[~2022-04-22  3:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22  3:55 lihuisong (C) [this message]
2022-04-22 11:41 ` Andrew Rybchenko
2022-04-24 10:03   ` lihuisong (C)
2022-04-29  1:47   ` lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2994c7eb-7ef4-d82d-0a49-ab3c9c8b675e@huawei.com \
    --to=lihuisong@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=huangdaode@huawei.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).