From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 38EE42951 for ; Tue, 31 May 2016 10:39:38 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id z87so97604935wmh.0 for ; Tue, 31 May 2016 01:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yfj6391FAFi8pfekjidpboiDTnLAuilHYmCz1MiuEoo=; b=Zvsz9Pkb/BvRIdzRTVBGBL4vuaE2fuOrZyi+uFoJcDyQKOSwuztBym2IYKG2zaMUhE PFgpXOKLGpw8zSkrw+8QC+xG0i024twHgKiCkVjYu8rHwhTzRd2SnOVWF+XBabmplPE3 4OUYQLNBgMqg8B6zwOlan7N/yXzVsiiygpObtPl7pe2qsodh4HIvEvMGIcOwJNuIaeWE PvwdddCHdpvVCAzLJWK70/LrLt5bzt58bz7H9kPZLIp3/y8bNNy69Mh1Q/GfqlBLZZAt c0H4rA81FkJWD76C5m2kxqkCTmnHO0vJF3jeWnyBHj+jgN9BkbgXLLMfvXNvAeBEqYXy 6QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Yfj6391FAFi8pfekjidpboiDTnLAuilHYmCz1MiuEoo=; b=g6RRynAW3YdI/IKWJl+uKk1HaRp5B7QqaC3QKEaU3aHHeUiWq366matlHW4Pruquo6 hp9ffNlLMPYvhsTxsJoS2Oli9WbyaO+w3BPyxWFkK7Jr7edr0XPTioIB0zu1gByat3wO oEnm6YyLCdo/WsvHXZYRpLJSZXrdKd8qwAvrrflMZ5i/Wy/z2bGY9XDTEVXjxfihuecv Bzkx4WAuABYgg6YzJ03faq+ViNr2ZYEmEodXb1+TUQDRI7DRRrk1Q77xQU88jf1neWAP RqO/u/XCj6CPnxkpFr/82tuPiKM7vrqP00cuJGob33yTiKVVSXil9zzdkvyXju8lLGL2 5LKQ== X-Gm-Message-State: ALyK8tI43YfkZSkaoi0kPR8JMNu5pNfpGmeqyS6QfkNS63Xfspz0ad45jBHVsCIFLkb7hnNP X-Received: by 10.28.19.210 with SMTP id 201mr15108061wmt.49.1464683977971; Tue, 31 May 2016 01:39:37 -0700 (PDT) Received: from xps13.localnet (134.20.90.92.rev.sfr.net. [92.90.20.134]) by smtp.gmail.com with ESMTPSA id d195sm28237039wmd.12.2016.05.31.01.39.36 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2016 01:39:37 -0700 (PDT) From: Thomas Monjalon To: Olivier MATZ Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com Date: Tue, 31 May 2016 10:39:33 +0200 Message-ID: <2996941.2Z82H6L4i5@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <574D3FA2.10301@6wind.com> References: <1464609857-30162-1-git-send-email-olivier.matz@6wind.com> <2644423.ubxL6r272Z@xps13> <574D3FA2.10301@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: log mbuf pool creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 08:39:38 -0000 2016-05-31 09:39, Olivier MATZ: > Hi Thomas, > > On 05/30/2016 09:44 PM, Thomas Monjalon wrote: > > 2016-05-30 14:04, Olivier Matz: > >> Enhance the logs related to mbuf pool creation. Display an info level > >> log when creating the mbuf, and display the error as a string on failure. > >> > >> After the patch, we have: > >> > >> [...] > >> EAL: probe driver: 8086:10fb rte_ixgbe_pmd > >> USER1: create a new mbuf pool : n=331456, \ > >> size=2176, socket=0 > >> EAL: Error - exiting with code: 1 > >> Cause: Creation of mbuf pool for socket 0 failed: Cannot allocate \ > >> memory > > > > Yes printing the error reason is a good improvement. > > But why the previous line is at INFO level? It looks to be a debug. > > > > Using INFO instead of DEBUG was done on purpose. I think the mbuf > pool parameters is a valuable information for the user running testpmd, > especially to ensure it's compatible with best performance. OK, seems reasonnable.