From: Thomas Monjalon <thomas@monjalon.net>
To: guohongzhi1@huawei.com
Cc: dev@dpdk.org, stable@dpdk.org, olivier.matz@6wind.com,
mb@smartsharesystems.com, konstantin.ananyev@intel.com,
jiayu.hu@intel.com, ferruh.yigit@intel.com,
nicolas.chautru@intel.com, cristian.dumitrescu@intel.com,
zhoujingbin@huawei.com, chenchanghu@huawei.com,
jerry.lilijun@huawei.com, haifeng.lin@huawei.com
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
Date: Wed, 24 Jun 2020 13:53:52 +0200 [thread overview]
Message-ID: <2998964.7raKxpcYx0@thomas> (raw)
In-Reply-To: <20200526100805.24896-1-guohongzhi1@huawei.com>
26/05/2020 12:08, guohongzhi:
> From: Hongzhi Guo <guohongzhi1@huawei.com>
>
> 0xffff is invalid for IPv4 checksum(RFC1624)
>
> Fixes: 6006818cfb26 ("net: new checksum functions")
> Cc: stable@dpdk.org
>
> Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
The Signed-off should be in chronological order, before reviews.
As suggested in previous patch, the title should be
net: fix IPv4 checksum
I am doing above modifications while merging.
More advices about submitting patches:
- use -v2, -v3, etc when sending new versions
- add a changelog below the line ---
- use --in-reply-to to keep all versions threaded
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
> {
> uint16_t cksum;
> cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> - return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> + return (uint16_t)~cksum;
> }
Applied, thanks
next prev parent reply other threads:[~2020-06-24 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 9:16 guohongzhi
2020-05-26 9:31 ` Morten Brørup
2020-05-14 1:27 guohongzhi
2020-05-24 15:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2998964.7raKxpcYx0@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).