From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7078F1B5E6 for ; Thu, 9 Nov 2017 23:48:16 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Nov 2017 14:48:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,371,1505804400"; d="scan'208";a="311189" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.59]) ([10.241.224.59]) by FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2017 14:48:14 -0800 To: Rasesh Mody , dev@dpdk.org, thomas.monjalon@6wind.com Cc: Harish Patil , Dept-EngDPDKDev@cavium.com References: <1510210340-5433-1-git-send-email-rasesh.mody@cavium.com> <1510210340-5433-2-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: <299dcd47-ca68-afe9-34ca-6c6be7a5cd8b@intel.com> Date: Thu, 9 Nov 2017 14:48:14 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510210340-5433-2-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 22:48:16 -0000 On 11/8/2017 10:52 PM, Rasesh Mody wrote: > From: Harish Patil > > Restore the default configuration as in previous releases and > add a debug msg. Is this reverting "f07aa795c92a ("net/qede: disable per-VF Tx switching feature")" This will be same as code before f07aa795c92a , right? If so why not just remove the config option for this release and add a dynamic runtime in next release? I am not clear for both f07aa795c92a and this one fixing, and why should they be included for rc3? Thanks, ferruh > > Fixes: f07aa795c92a ("net/qede: disable per-VF Tx switching feature") > > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > config/common_base | 2 +- > drivers/net/qede/qede_ethdev.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/config/common_base b/config/common_base > index 34f04a9..e74febe 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -415,7 +415,7 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n > -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n > +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=y > #Provides abs path/name of the firmware file. > #Empty string denotes driver will use default firmware > CONFIG_RTE_LIBRTE_QEDE_FW="" > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index 8832145..6f5ba2a 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -457,6 +457,7 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg) > if (IS_VF(edev)) { > params.update_tx_switching_flg = 1; > params.tx_switching_flg = !flg; > + DP_INFO(edev, "VF tx-switching is disabled\n"); > } > #endif > for_each_hwfn(edev, i) { > @@ -469,8 +470,8 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg) > break; > } > } > - DP_INFO(edev, "vport %s VF tx-switch %s\n", flg ? "activated" : "deactivated", > - params.tx_switching_flg ? "enabled" : "disabled"); > + DP_INFO(edev, "vport is %s\n", flg ? "activated" : "deactivated"); > + > return rc; > } > >