From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 917C9293B for ; Fri, 24 Aug 2018 10:48:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2018 01:48:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,281,1531810800"; d="scan'208";a="67522811" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 24 Aug 2018 01:48:32 -0700 To: "dev@dpdk.org" , Thomas Monjalon , Adrien Mazarguil , "Xueming(Steven) Li" , Shahaf Shuler , Andrew Rybchenko References: <2d087000-8e07-4c31-eeea-1fd5e90b6cfa@intel.com> <20180824071711.u2xefstgefadh437@MTBC-JACKMIN.mtl.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <29a35612-9936-a901-2937-e18643901925@intel.com> Date: Fri, 24 Aug 2018 09:48:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180824071711.u2xefstgefadh437@MTBC-JACKMIN.mtl.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add generic TTL rewrite actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 08:48:37 -0000 On 8/24/2018 8:17 AM, Jack MIN wrote: > On Thu, Aug 23, 2018 at 03:00:53PM +0100, Ferruh Yigit wrote: >> On 8/7/2018 3:20 PM, Jack Min wrote: >>> There is a need to rewrite TTL by decrease or just set it directly, >>> and it's not necessary to check if the final result is zero or not. >>> >>> This is slightly different from the one defined by openflow and >>> make the actions more generic. >>> >>> >>> >>> >>> Signed-off-by: Xiaoyu Min >> >> Looks good to me. >> >> Can we use existing testpmd commands to test these new actions? > No, I don't think so. Can you please update testpmd counterpart of new actions so that they can be tested? > The current TTL related testpmd commands are all for OpenFlow variety > > -Jack >