From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: "David Marchand" <david.marchand@redhat.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
dev@dpdk.org, "Luka Jankovic" <luka.jankovic@ericsson.com>,
"Thomas Monjalon" <thomas@monjalon.net>
Subject: Re: [PATCH] bitops: fix issue in parallel atomic tests
Date: Mon, 14 Oct 2024 16:33:31 +0200 [thread overview]
Message-ID: <29b26346-8ccc-4d7b-97b6-f77bd5fc85fb@lysator.liu.se> (raw)
In-Reply-To: <CAJFAV8wfEKP7mM_Xr_sBFM5Q_AZNBdEbzz1mSViN-Wb-Zj1tWg@mail.gmail.com>
On 2024-10-14 16:16, David Marchand wrote:
> On Sun, Oct 13, 2024 at 5:37 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>>> I'm far from sure it's a compiler bug. Just look at the base rate: how
>>> often does the code you just wrote fail because of a bug in your code,
>>> and how often is the root cause to be found in the compiler or the
>>> standard libraries.
>>>
>>
>> A strong argument for rootcausing exactly what the specific compiler gets wrong when compiling the code triggering the error.
>>
>
> I agree that root causing it is preferrable.
> I merged this change in any case to resolve the false positives in CI.
>
>
The change is reworking some pretty awkward, potentially incorrect (if
GCC 12.2 is right and I am wrong) code. So it should be merged in any
case. The reason the reference word was always 64 bit was just an
oversight on my part.
next prev parent reply other threads:[~2024-10-14 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 11:57 Mattias Rönnblom
2024-10-13 13:37 ` Morten Brørup
2024-10-13 15:19 ` Mattias Rönnblom
2024-10-13 15:36 ` Morten Brørup
2024-10-14 14:16 ` David Marchand
2024-10-14 14:33 ` Mattias Rönnblom [this message]
2024-10-14 14:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b26346-8ccc-4d7b-97b6-f77bd5fc85fb@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=luka.jankovic@ericsson.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).