From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1DBDB45B38;
	Mon, 14 Oct 2024 16:33:37 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DB6C24027F;
	Mon, 14 Oct 2024 16:33:36 +0200 (CEST)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by mails.dpdk.org (Postfix) with ESMTP id 1A2354060A
 for <dev@dpdk.org>; Mon, 14 Oct 2024 16:33:35 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 8601910180
 for <dev@dpdk.org>; Mon, 14 Oct 2024 16:33:33 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 7AA31FFFF; Mon, 14 Oct 2024 16:33:33 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on
 hermod.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL,
 T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0
X-Spam-Score: -1.2
Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se
 [62.63.215.114])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id AC139FFFE;
 Mon, 14 Oct 2024 16:33:31 +0200 (CEST)
Message-ID: <29b26346-8ccc-4d7b-97b6-f77bd5fc85fb@lysator.liu.se>
Date: Mon, 14 Oct 2024 16:33:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bitops: fix issue in parallel atomic tests
To: David Marchand <david.marchand@redhat.com>,
 =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org, Luka Jankovic <luka.jankovic@ericsson.com>,
 Thomas Monjalon <thomas@monjalon.net>
References: <20241013115719.820853-1-mattias.ronnblom@ericsson.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F7CD@smartserver.smartshare.dk>
 <56e72271-2e4c-4ea4-b7b4-e7662202116c@lysator.liu.se>
 <98CBD80474FA8B44BF855DF32C47DC35E9F7CE@smartserver.smartshare.dk>
 <CAJFAV8wfEKP7mM_Xr_sBFM5Q_AZNBdEbzz1mSViN-Wb-Zj1tWg@mail.gmail.com>
Content-Language: en-US
From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>
In-Reply-To: <CAJFAV8wfEKP7mM_Xr_sBFM5Q_AZNBdEbzz1mSViN-Wb-Zj1tWg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024-10-14 16:16, David Marchand wrote:
> On Sun, Oct 13, 2024 at 5:37 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>>> I'm far from sure it's a compiler bug. Just look at the base rate: how
>>> often does the code you just wrote fail because of a bug in your code,
>>> and how often is the root cause to be found in the compiler or the
>>> standard libraries.
>>>
>>
>> A strong argument for rootcausing exactly what the specific compiler gets wrong when compiling the code triggering the error.
>>
> 
> I agree that root causing it is preferrable.
> I merged this change in any case to resolve the false positives in CI.
> 
> 

The change is reworking some pretty awkward, potentially incorrect (if 
GCC 12.2 is right and I am wrong) code. So it should be merged in any 
case. The reason the reference word was always 64 bit was just an 
oversight on my part.