From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37624A034C; Wed, 21 Dec 2022 10:28:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2706740A7A; Wed, 21 Dec 2022 10:28:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2C68E40698 for ; Wed, 21 Dec 2022 10:28:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671614931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNJaIhNu8RZVk1ApalQUJHSl2nUF3CQ0z5yrmftuBjo=; b=UU+WCSZsqWvP+EAM8YKa2Tu6Ga+x6Opi655NHHPLzt5fjAezpGhXMdc4yaeceUhJnQcYVz jD/MG53tzLNsn+goBNdGbloDQ7p8O5WJ90Yvl7kKKnwLF5ggR4MLon/5Pfbeyi8gGd9Iqv ud8ERnqRwwIdYlUIuFWdWmvnLa+6L5c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-649-H0SLmTdrNveMAYO9v_dRzw-1; Wed, 21 Dec 2022 04:28:50 -0500 X-MC-Unique: H0SLmTdrNveMAYO9v_dRzw-1 Received: by mail-wr1-f70.google.com with SMTP id h10-20020adfaa8a000000b0024208cf285eso2733039wrc.22 for ; Wed, 21 Dec 2022 01:28:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZNJaIhNu8RZVk1ApalQUJHSl2nUF3CQ0z5yrmftuBjo=; b=37FNauo5REgIAYg7zkVMJz84JcbFAdMy1dJvzJvf1Tre7gsBCFzwuvrkwhq/h3L6fr 8hcMnuhzA/MouWzHgsLBdgsDRPEFK6fsZy36E91d5pK+liUg6mhgJLBeKtdn/mMW5KdI 73U0K4ie0mJ1DhcQ7irKiAWEriIDW3Xu1pVI/jtsXyHrwKae9zMbqueHEi4eYFDgRcp6 By65qHMgimBOQbbqRdeejTQw+h808t0b8NlAjp9STQKgUdrxtXlV91yJ010pruuCK9qD O8SZKQckXpC3gI3jIxS6MPfifNyArHAQ+ga3xtnfr3FISqUEMZbMoAUXUeFbiGUEDPs9 WsOQ== X-Gm-Message-State: AFqh2koNTGnt6yG3JTba+d9WFvJvMh3dVysYrPAolgKWM6KAOKhT2NAO qavEky8bqIYZHfTGkYDkkA4Tp+btue0Lf+/GVw4qKkib5WedUaXKAgzHx2e0KS3f6kXRj13ob/J o+vY= X-Received: by 2002:adf:f1c9:0:b0:242:1d69:1ba1 with SMTP id z9-20020adff1c9000000b002421d691ba1mr687495wro.44.1671614929228; Wed, 21 Dec 2022 01:28:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXt5A2uUY0ZsRoWHtkyyxdTXMCPOtKe8J3HAEfs70F/fG7Sjb4sdZII18QUaMkQAJ5mjJDqHvA== X-Received: by 2002:adf:f1c9:0:b0:242:1d69:1ba1 with SMTP id z9-20020adff1c9000000b002421d691ba1mr687480wro.44.1671614929011; Wed, 21 Dec 2022 01:28:49 -0800 (PST) Received: from [192.168.0.36] ([78.17.251.111]) by smtp.gmail.com with ESMTPSA id ay9-20020a5d6f09000000b002425504ae7dsm14881685wrb.80.2022.12.21.01.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 01:28:48 -0800 (PST) Message-ID: <29f03d86-bc81-c39f-76b1-bb51b9999cfb@redhat.com> Date: Wed, 21 Dec 2022 09:28:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 To: Andrew Rybchenko , Ciara Loftus , dev@dpdk.org, "Zhang, Qi Z" Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com References: <20220624102354.1516606-1-ciara.loftus@intel.com> <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> From: Kevin Traynor In-Reply-To: <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/12/2022 06:09, Andrew Rybchenko wrote: > Hi Kevin, > > On 12/20/22 17:05, Kevin Traynor wrote: >> On 24/06/2022 11:23, Ciara Loftus wrote: >>> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd >>> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if >>> so, use >>> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach >>> and bpf_xdp_detach which are available to use since libbpf v0.7.0. >>> >>> Also prevent linking with libbpf versions > v0.8.0. >>> >>> Signed-off-by: Ciara Loftus >> >> Hi Andrew/Qi (assuming Ciara is still out of office), >> >> I am seeing a similar issue [1] on 21.11 branch with Fedora 37 >> (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). >> >> This patch alone won't apply as there are other dependencies. Looking at >> the commits in main branch, it seems like I could take all these [2] to >> resolve the issue. With these cherry-picked the build warnings on Fedora >> 37 are removed. >> >> It's a bit late to take these for DPDK 21.11.3 as I intend to release >> later today/tomorrow, so it can be resolved for DPDK 21.11.4. >> >> Do the commits below look ok for backport? Main branch might be able to >> demand user uses new libbpf/libxdp versions etc, but with stable we >> never want to break the users existing setup when they upgrade from >> 2X.11.n to 2X.11.n+1. >> >> Let me know what you think? > > IMO these patches are to to be backported to stable branch. Thanks Andrew. > However, af_xdp maintainers opinion is more important here. > Qi, what do you think? >> >> thanks, >> Kevin. >> >> [1] https://paste.centos.org/view/e4eec764 >> [2] >> 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 >> 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures >> 0ed0bc3834 net/af_xdp: avoid version-based check for program load >> e024c7e838 net/af_xdp: avoid version-based check for shared UMEM >> f76dc44ded net/af_xdp: make clear which libxdp version is required >> 50b855fc47 net/af_xdp: move XDP library presence flag setting >> >