From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yskoh@mellanox.com>
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0045.outbound.protection.outlook.com [104.47.1.45])
 by dpdk.org (Postfix) with ESMTP id 3303B1B2A4
 for <dev@dpdk.org>; Wed, 14 Feb 2018 19:13:22 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=JPccpIIP/4ZuxoXBlhG5PaYFYTZwyzaFDZz+h+O2V/o=;
 b=iLRlpbS2TWJzmr/9HqF9xsTd6BiiSzdm8jmNq53wV21fUFc2zp0auEKrRACO+Et2sJJJfhySYajBK5VpW0pSiEACUyxoZD6q47PMITS8o2J71adVb4FjAfnnhXJhEiuZMZ/d9HezMeaEM6c2fba+8F0eGoClCxhssaTzAnVKuHY=
Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by
 VI1PR0501MB2414.eurprd05.prod.outlook.com (10.168.135.146) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Wed, 14
 Feb 2018 18:13:20 +0000
Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com
 ([fe80::5ccf:86b:106c:a93a]) by VI1PR0501MB2045.eurprd05.prod.outlook.com
 ([fe80::5ccf:86b:106c:a93a%14]) with mapi id 15.20.0485.017; Wed, 14 Feb 2018
 18:13:20 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
CC: "Walker, Benjamin" <benjamin.walker@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 "andras.kovacs@ericsson.com" <andras.kovacs@ericsson.com>, "Wiles, Keith"
 <keith.wiles@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>, "Shahaf
 Shuler" <shahafs@mellanox.com>, "Xueming(Steven) Li" <xuemingl@mellanox.com>
Thread-Topic: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK
Thread-Index: AQHTfm3YBB6w6AxuJE+TFa+5PaJlCqORNQ0AgASfQoCADZ5nAIAAfdAAgACRoIA=
Date: Wed, 14 Feb 2018 18:13:20 +0000
Message-ID: <2B4E1FED-A27C-4F41-9A85-38D41A010D14@mellanox.com>
References: <cover.1513681966.git.anatoly.burakov@intel.com>
 <1513892309.2658.80.camel@intel.com>
 <c1a8f9f5-390d-c9ea-958a-85c0bcac60b3@intel.com>
 <1514308764.2658.93.camel@intel.com>
 <20180202192832.GA42096@yongseok-MBP.local>
 <afbeaf2a-3d5b-544e-d6ae-0d6b6d2f6023@intel.com>
 <A7103C84-AF2F-4AF3-B87E-EB02F9B6BFFB@mellanox.com>
 <bd60f799-69b4-b3d7-4e53-f81e7df3abc7@intel.com>
In-Reply-To: <bd60f799-69b4-b3d7-4e53-f81e7df3abc7@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=yskoh@mellanox.com; 
x-originating-ip: [209.116.155.178]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2414;
 7:+Ue3Wg9etZ0chRRBodHqqM70vguSY7QFYfetZl32Lo/OehM8dArsSIle0NI2/zkgxtgk7uke4KOnpzVTliCptllRWHLdWOcPK/1ambVQDsWdLo4ngr7kAn+7TYPTZuDE7TrH9k3eWGvc/bX26EGSrYnS+U2bxkydBF3KFQfcsybVm6NQlxz/nmYIBfiLeQAtSGEyzVSL5OMQPrV++/zinSBjP/pFqbQB8U0flukZmJY3iJiw6UlopxBTRtTebTUr
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 13919824-068a-4869-e348-08d573d6a124
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);
 SRVR:VI1PR0501MB2414; 
x-ms-traffictypediagnostic: VI1PR0501MB2414:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <VI1PR0501MB24144EDC834CA5FA3C8952FEC3F50@VI1PR0501MB2414.eurprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(6041288)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);
 SRVR:VI1PR0501MB2414; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2414; 
x-forefront-prvs: 0583A86C08
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(396003)(366004)(39860400002)(376002)(39380400002)(346002)(189003)(199004)(6512007)(4326008)(25786009)(6436002)(105586002)(86362001)(53936002)(107886003)(6486002)(229853002)(102836004)(186003)(2906002)(5660300001)(97736004)(5250100002)(81166006)(7736002)(81156014)(26005)(6506007)(8936002)(33656002)(8676002)(53546011)(93886005)(305945005)(68736007)(3660700001)(106356001)(2950100002)(36756003)(6916009)(6246003)(54906003)(82746002)(66066001)(3280700002)(316002)(99286004)(14454004)(76176011)(478600001)(6116002)(3846002)(83716003)(2900100001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2414;
 H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
 MX:1; A:1; LANG:en; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: g94BXVoXqVqw/kf3SF+SkcnNGDMHw6TYUZiijN3tPCWg6RfDBmw9pcqUaOdVfe9cHzeVgk++jdWEdv4g96SuoA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <7C304BC3ACA3C840BC2768396ED0A367@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13919824-068a-4869-e348-08d573d6a124
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2018 18:13:20.5756 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2414
Subject: Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2018 18:13:22 -0000



> On Feb 14, 2018, at 1:32 AM, Burakov, Anatoly <anatoly.burakov@intel.com>=
 wrote:
>=20
> On 14-Feb-18 2:01 AM, Yongseok Koh wrote:
>>> On Feb 5, 2018, at 2:03 AM, Burakov, Anatoly <anatoly.burakov@intel.com=
> wrote:
>>>=20
>>> Thanks for your feedback, good to hear we're on the right track. I alre=
ady have a prototype implementation of this working, due for v1 submission =
:)
>> Anatoly,
>> One more suggestion. Currently, when populating mempool, there's a chanc=
e to
>> have multiple chunks if system memory is highly fragmented. However, wit=
h your
>> new design, it is unlikely to happen unless the system is really low on =
memory.
>> Allocation will be dynamic and page by page. With your v2, you seemed to=
 make
>> minimal changes on mempool. If allocation fails, it will still try to ga=
ther
>> fragments from malloc_heap until it acquires enough objects and the resu=
ltant
>> mempool will have multiple chunks. But like I mentioned, it is very unli=
kely and
>> this will only happen when the system is short of memory. Is my understa=
nding
>> correct?
>> If so, how about making a change to drop the case where mempool has mult=
iple
>> chunks?
>> Thanks
>> Yongseok
>=20
> Hi Yongseok,
>=20
> I would still like to keep it, as it may impact low memory cases such as =
containers.

Agreed. I overlooked that kind of use-cases.

Thanks,
Yongseok=