From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 96D2A2B9D for ; Mon, 7 Aug 2017 15:17:19 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2017 06:17:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,338,1498546800"; d="scan'208";a="136635563" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 07 Aug 2017 06:17:18 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.214]) by fmsmsx104.amr.corp.intel.com ([169.254.3.177]) with mapi id 14.03.0319.002; Mon, 7 Aug 2017 06:17:18 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] usertools: script to output version string Thread-Index: AQHS9mgu7r+tVMb9+kGgrfIcgqD9aaJ5awmAgAAceQA= Date: Mon, 7 Aug 2017 13:17:17 +0000 Message-ID: <2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com> References: <20170706145649.65075-1-keith.wiles@intel.com> <2588998.vour8g1xmE@xps> In-Reply-To: <2588998.vour8g1xmE@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.230.19] Content-Type: text/plain; charset="us-ascii" Content-ID: <39C37A1C965CFC40994FB82151D80566@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] usertools: script to output version string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2017 13:17:20 -0000 > On Aug 7, 2017, at 6:35 AM, Thomas Monjalon wrote: >=20 > Hi, >=20 > 06/07/2017 16:56, Keith Wiles: >> +# Locate the rte_version.h file and parse out the version strings. >=20 > I think this script is not needed because we have already > something in mk/rte.sdkconfig.mk. > Example: > % make showversion > 17.08.0-rc4 Executing make to find out a version seems to bit of over kill to me and a = simple script would be much easier IMO. I do not really see harm in having = this script that can output the version into different formats is helpful w= hen running external scripts. Also in the future we are most like going to = replace the build system and then we would need to add this support to that= build system and having it in a standalone script is easier manage in the = long run. >=20 > Do you need more? Regards, Keith