From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B1A303230 for ; Fri, 23 Jun 2017 02:41:48 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2017 17:41:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,375,1493708400"; d="scan'208";a="102685640" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 22 Jun 2017 17:41:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Jun 2017 17:41:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Fri, 23 Jun 2017 08:41:44 +0800 From: "Chang, Cunyin" To: Stephen Hemminger CC: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 2/3] eal: PCI domain should be 32 bits Thread-Index: AQHS6qyWZKTqhZpoWUeorTUcdVX5Z6Iwlx/Q///sRACAAQv+gA== Date: Fri, 23 Jun 2017 00:41:43 +0000 Message-ID: <2BFA8F2383C3784C90698C10BC0963195EEEF974@SHSMSX103.ccr.corp.intel.com> References: <20170621163545.25713-1-stephen@networkplumber.org> <20170621163545.25713-3-stephen@networkplumber.org> <2BFA8F2383C3784C90698C10BC0963195EEEF678@SHSMSX103.ccr.corp.intel.com> <20170622085134.598451d3@xeon-e3> In-Reply-To: <20170622085134.598451d3@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdmYjMzNDItMDVhOS00MmE0LTlhNDktNWE1YTgxYzUzZThlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlHSzJRSUhFcVhWRUxKRVFFelBLUkhqS28zVEpEcmdxSVJCU3RKZmM2QTA9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] eal: PCI domain should be 32 bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 00:41:49 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, June 22, 2017 11:52 PM > To: Chang, Cunyin > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/3] eal: PCI domain should be 32 bits >=20 > On Thu, 22 Jun 2017 09:28:31 +0000 > "Chang, Cunyin" wrote: >=20 > > I think the series patches does not cover all area which need to adapt > > to u32 PCI domain, We still need some other work to do: > > we need define another macro such as PCI_PRI_FMT. Something like: > > #define PCI_XXX_PRI_FMT "%.5" PRIx32 ":%.2" PRIx8 ":%.2" PRIx8 ".%" > > PRIx8 > > > > PCI_PRI_STR_SIZE also need to be modified: > > #define PCI_PRI_STR_SIZE sizeof("XXXXX:XX:XX.X") > > > > The macro PCI_PRI_FMT will not works if The domain exceed 16bits. It > > will impact the following functions: > > 1 RTE_LOG function, there a lots of RTE_LOG such as: > > RTE_LOG(WARNING, EAL, > > "Requested device " PCI_PRI_FMT " cannot be > used\n", > > addr->domain, addr->bus, addr->devid, addr- > >function); > > 2 pci_dump_one_device(). > > 3 rte_eal_pci_device_name() > > 4 pci_update_device() > > 5 pci_ioport_map() > > 6 pci_get_uio_dev() > > 7 pci_uio_map_resource_by_index() > > 8 pci_uio_ioport_map() > > 9 pci_vfio_map_resource() > > 10 pci_vfio_unmap_resource() > > All the above functions will related with the macro PCI_PRI_FMT, so I t= hink > they need to be modified too. > > > > There are some other code need modify: > > In function rte_eal_compare_pci_addr(), we need do the following work: > > dev_addr =3D ((uint64_t)addr->domain << 24) | ((uint64_t)addr->bus << 1= 6) | > > ((uint64_t)addr->devid << 8) | > (uint64_t)addr->function; > > dev_addr2 =3D ((uint64_t)addr2->domain << 24) | ((uint64_t)addr2->bus <= < > 16) | > > ((uint64_t)addr2->devid << 8) | > (uint64_t)addr2->function; > > > > In function eal_parse_pci_BDF(), we need do the following work: > > GET_PCIADDR_FIELD(input, dev_addr->domain, UINT32_MAX, ':'); >=20 > Good catch, the string size must be increased. >=20 > It turns out that you don't need to change the PCI print format. Printing= the > domain with %.4x works correctly with 32 bit. It just gets wider. This is= how > pciutils works, so no change is necessary there. I suppose we should use %4x, not %.4x?, the %.4x will cut the 10000:05:00.0= as 0000:05:00.0. So the macro: #define PCI_PRI_FMT "%.4" PRIx32 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 Should be: #define PCI_PRI_FMT "%4" PRIx32 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 Make sense? >=20 > For normal 16 bit domain, the print will be: > 0000:05.00.0 > and for these 32 bit values > 100000:05:00.0 >=20 > Yes, the compare needs domain cast to 64 bit. The bus/devid/function don'= t > need cast.