From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7D5701094 for ; Tue, 28 Mar 2017 07:39:59 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 27 Mar 2017 22:39:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,235,1486454400"; d="scan'208";a="1147759086" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 27 Mar 2017 22:39:58 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 22:39:58 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 22:39:58 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.212]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.46]) with mapi id 14.03.0248.002; Tue, 28 Mar 2017 13:39:56 +0800 From: "Yao, Lei A" To: Maxime Coquelin , "aconole@redhat.com" , "sodey@sonusnet.com" , "yuanhan.liu@linux.intel.com" , "Tan, Jianfeng" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support Thread-Index: AQHSm06P9iPPu4fvdE6mDyPJqaKpb6Gp05XQ Date: Tue, 28 Mar 2017 05:39:55 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A175FB5@shsmsx102.ccr.corp.intel.com> References: <20170213142820.8964-1-maxime.coquelin@redhat.com> <20170312163406.17714-1-maxime.coquelin@redhat.com> In-Reply-To: <20170312163406.17714-1-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 05:40:01 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Monday, March 13, 2017 12:34 AM > To: aconole@redhat.com; sodey@sonusnet.com; > yuanhan.liu@linux.intel.com; Tan, Jianfeng ; > thomas.monjalon@6wind.com; dev@dpdk.org > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support >=20 > This series adds support to new Virtio's MTU feature[1]. The MTU > value is set via QEMU parameters. >=20 > If the feature is negotiated (i.e supported by both host and guest, > and valid MTU value is set in QEMU via its host_mtu parameter), QEMU > shares the configured MTU value throught dedicated Vhost protocol > feature. >=20 > On vhost side, the value is stored in the virtio_net structure, and > made available to the application thanks to new vhost lib's > rte_vhost_get_mtu() function. >=20 > To be able to set eth_dev's MTU value at the right time, i.e. to call > rte_vhost_get_mtu() just after Virtio features have been negotiated > and before the device is really started, a new vhost flag has been > introduced (VIRTIO_DEV_READY), because the VIRTIO_DEV_RUNNING flag is > set too late (after .new_device() ops is called). >=20 > Regarding valid MTU values, the maximum MTU value accepted on vhost > side is 65535 bytes, as defined in Virtio Spec and supported in > Virtio-net Kernel driver. But in Virtio PMD, current maximum frame > size is 9728 bytes (~9700 bytes MTU). So maximum MTU size accepted in > Virtio PMD is the minimum between ~9700 bytes and host's MTU. >=20 > Finally, this series also adds MTU value printing in testpmd's > "show port info" command when non-zero. >=20 > This series target v17.05 release. >=20 > Cheers, > Maxime >=20 > [1]: https://lists.oasis-open.org/archives/virtio-dev/201609/msg00128.htm= l >=20 > Changes since v1: > ----------------- > * Rebased on top of v17.02 > * Virtio PMD: ensure MTU value is valid before ack'ing the feature (Aaron= ) > * Vhost lib/PMD: Remove MTU setting API/op (Yuanhan) >=20 > Changes since v2: > ----------------- > * Update release notes (Thomas) > * s/rte_vhost_mtu_get/rte_vhost_get_mtu/ (Yuanhan) > * Use %"PRIu64" instead of %lu (Yuanhan) > * Add rte_vhost_get_mtu in rte_vhost_version.map >=20 > Maxime Coquelin (9): > vhost: Enable VIRTIO_NET_F_MTU feature > vhost: vhost-user: Add MTU protocol feature support > vhost: Add new ready status flag > vhost: Add API to get MTU value > vhost: export MTU value > net/vhost: Fill rte_eth_dev's MTU property > net/virtio: Add MTU feature support > doc: announce Virtio and Vhost MTU support > app/testpmd: print MTU value in show port info >=20 > app/test-pmd/config.c | 5 ++++ > doc/guides/nics/features/virtio.ini | 1 + > doc/guides/rel_notes/release_17_05.rst | 8 ++++++ > drivers/net/vhost/rte_eth_vhost.c | 2 ++ > drivers/net/virtio/virtio_ethdev.c | 45 > ++++++++++++++++++++++++++++++++-- > drivers/net/virtio/virtio_ethdev.h | 3 ++- > drivers/net/virtio/virtio_pci.h | 3 +++ > lib/librte_vhost/rte_vhost_version.map | 7 ++++++ > lib/librte_vhost/rte_virtio_net.h | 15 ++++++++++++ > lib/librte_vhost/vhost.c | 22 ++++++++++++++++- > lib/librte_vhost/vhost.h | 9 ++++++- > lib/librte_vhost/vhost_user.c | 44 +++++++++++++++++++++++++++-= -- > --- > lib/librte_vhost/vhost_user.h | 5 +++- > 13 files changed, 156 insertions(+), 13 deletions(-) >=20 > -- > 2.9.3 Hi, Maxime If I want have a try for this MTU function, is there any specific requireme= nt for the settings?=20 Such as the qemu version, kernel version or any others? Looks like this fea= ture are very new=20 in Qemu and linux side.=20 Thanks a lot! BRs Lei