From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1E988FE5 for ; Fri, 31 Mar 2017 09:00:05 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 31 Mar 2017 00:00:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="840309171" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2017 00:00:04 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 31 Mar 2017 00:00:03 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 31 Mar 2017 00:00:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.212]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.253]) with mapi id 14.03.0248.002; Fri, 31 Mar 2017 15:00:01 +0800 From: "Yao, Lei A" To: "Yigit, Ferruh" , "Yang, Zhiyong" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour Thread-Index: AQHSqF0FSMBBEMvMC0qkNDD2MDUJmaGs0tMAgAGyfJA= Date: Fri, 31 Mar 2017 07:00:01 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A1798FA@shsmsx102.ccr.corp.intel.com> References: <1488539851-71009-2-git-send-email-zhiyong.yang@intel.com> <1490771776-3362-1-git-send-email-zhiyong.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 07:00:06 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, March 30, 2017 8:55 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, > Bruce > Subject: Re: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour >=20 > On 3/29/2017 8:16 AM, Zhiyong Yang wrote: > > The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to > > transmit output packets on the output queue for DPDK applications as > > follows. > > > > static inline uint16_t > > rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id, > > struct rte_mbuf **tx_pkts, uint16_t nb_pkts); > > > > Note: The fourth parameter nb_pkts: The number of packets to transmit. > > > > The rte_eth_tx_burst() function returns the number of packets it actual= ly > > sent. Most of PMD drivers can support the policy "send as many packets = to > > transmit as possible" at the PMD level. but the few of PMDs have some > sort > > of artificial limits for the pkts sent successfully. For example, VHOST= tx > > burst size is limited to 32 packets. Some rx_burst functions have the > > similar problem. The main benefit is consistent batching behavior for u= ser > > to simplify their logic and avoid misusage at the application level, th= ere > > is unified rte_eth_tx/rx_burst interface already, there is no reason fo= r > > inconsistent behaviors. > > This patchset fixes it via adding wrapper function at the PMD level. > > > > Changes in V3: > > > > 1. Updated release_17_05 in patch 5/5 > > 2. Rebase on top of next net tree. i40e_rxtx_vec_altivec.c is updated i= n > > patch 2/5. > > 3. fix one checkpatch issue in 2/5. > > > > Changes in V2: > > 1. rename ixgbe, i40e and fm10k vec function XXX_xmit_pkts_vec to new > name > > XXX_xmit_fixed_burst_vec, new wrapper functions use original name > > XXX_xmit_pkts_vec according to Bruce's suggestion. > > 2. simplify the code to avoid the if or if/else. > > > > Zhiyong Yang (5): > > net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size > > net/i40e: remove limit of i40e_xmit_pkts_vec burst size > > net/ixgbe: remove limit of ixgbe_xmit_pkts_vec burst size > > net/vhost: remove limit of vhost TX burst size > > net/vhost: remove limit of vhost RX burst size >=20 > Series applied to dpdk-next-net/master, thanks. >=20 > (doc patch exported into separate patch) >=20 > This is the PMD update on fast path, effected PMDs, can you please > confirm the performance after test? Hi,=20 I have compare the vhost PVP performance with and without Zhiyong's=20 Patch. Almost no performance drop Mergeable path: -0.2% Normal Path: -0.73% Vector Path : -0.55% Test bench: Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 BRs Lei