From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2969B9E3; Fri, 28 Apr 2017 09:47:54 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 00:47:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="95207545" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 28 Apr 2017 00:47:52 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:47:52 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:47:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 15:47:50 +0800 From: "Yao, Lei A" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size Thread-Index: AQHSvoB81qzQrcZONEOHExNGXFaCuqHaadrA Date: Fri, 28 Apr 2017 07:47:49 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com> References: <1493206192-69422-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1493206192-69422-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 07:47:54 -0000 I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency = can=20 be changed according to the data throughput.=20 Tested-by: Lei Yao (lei.a.yao@intel.com) > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, April 26, 2017 7:30 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size >=20 > L3fwd power app monitors the RX queues to see if the polling frequency > should be adjusted (the busier the queue, the higher the frequency). > The app uses several thresholds in the ring to determine the frequency, > being 96 the highest one, when frequency should be highest. >=20 > The problem is that the difference between this value and the ring size > is not big enough (128 - 96 =3D 32 descriptors), which means that > if the descriptors are not replenished quick enough, queue might > not be busy, but the app would think that it is, because 96th descriptor > is set. >=20 > Therefore, by increasing this gap (increasing the RX ring size), > we make sure that this false measurement will not happen. >=20 > Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX > queue count") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > --- > examples/l3fwd-power/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index ec40a17..7a8e1cd 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -147,7 +147,7 @@ > /* > * Configurable number of RX/TX ring descriptors > */ > -#define RTE_TEST_RX_DESC_DEFAULT 128 > +#define RTE_TEST_RX_DESC_DEFAULT 512 > #define RTE_TEST_TX_DESC_DEFAULT 512 > static uint16_t nb_rxd =3D RTE_TEST_RX_DESC_DEFAULT; > static uint16_t nb_txd =3D RTE_TEST_TX_DESC_DEFAULT; > -- > 2.7.4