DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed
Date: Thu, 13 Jul 2017 08:18:15 +0000	[thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A21EC63@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170710080648.63443-1-zhiyong.yang@intel.com>



> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Monday, July 10, 2017 4:07 PM
> To: dev@dpdk.org
> Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com; Yao, Lei A
> <lei.a.yao@intel.com>; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] vhost: fix vhost-user init failed
> 
> Exception handling is executed in the normal path and it will cause
> vhost-user init failure.
> Fixes: d6983a70e259("vhost: check return of pthread calls")
> 
> Reported-by: Lei Yao <lei.a.yao@intel.com>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Tested-by: Lei Yao <lei.a.yao@intel.com>
This patch can fix the vhost-init issue on my server. 

> ---
>  lib/librte_vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 57b86c0..9d2049c 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -668,7 +668,7 @@ rte_vhost_driver_register(const char *path, uint64_t
> flags)
>  	}
> 
>  	vhost_user.vsockets[vhost_user.vsocket_cnt++] = vsocket;
> -
> +	goto out;
>  out_mutex:
>  	if (pthread_mutex_destroy(&vsocket->conn_mutex)) {
>  		RTE_LOG(ERR, VHOST_CONFIG,
> --
> 2.9.3

      parent reply	other threads:[~2017-07-13  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  8:06 Zhiyong Yang
2017-07-10  9:38 ` Maxime Coquelin
2017-07-10  9:48 ` Jens Freimann
2017-07-12  2:41   ` Liu, Yu Y
2017-07-14  2:43   ` Yuanhan Liu
2017-07-13  8:18 ` Yao, Lei A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2DBBFF226F7CF64BAFCA79B681719D953A21EC63@shsmsx102.ccr.corp.intel.com \
    --to=lei.a.yao@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yliu@fridaylinux.org \
    --cc=zhiyong.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).