From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 00C322935 for ; Thu, 13 Jul 2017 10:18:19 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2017 01:18:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,353,1496127600"; d="scan'208";a="110803129" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 13 Jul 2017 01:18:18 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 13 Jul 2017 01:18:18 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 13 Jul 2017 01:18:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Thu, 13 Jul 2017 16:18:16 +0800 From: "Yao, Lei A" To: "Yang, Zhiyong" , "dev@dpdk.org" CC: "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" Thread-Topic: [PATCH] vhost: fix vhost-user init failed Thread-Index: AQHS+VOKps5sq84zAUGI0pQpQLjF56JRbeaA Date: Thu, 13 Jul 2017 08:18:15 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A21EC63@shsmsx102.ccr.corp.intel.com> References: <20170710080648.63443-1-zhiyong.yang@intel.com> In-Reply-To: <20170710080648.63443-1-zhiyong.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDFmZDdmZTktNzI1ZS00NTc2LTg5YzQtMzA4YWFhZTU0OWZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdWS3Q4b0pPYmRDRG0rYlJISlRUTWF3WmUxTnl1cDI0Sjgyeksxbk9zVU09In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 08:18:20 -0000 > -----Original Message----- > From: Yang, Zhiyong > Sent: Monday, July 10, 2017 4:07 PM > To: dev@dpdk.org > Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com; Yao, Lei A > ; Yang, Zhiyong > Subject: [PATCH] vhost: fix vhost-user init failed >=20 > Exception handling is executed in the normal path and it will cause > vhost-user init failure. > Fixes: d6983a70e259("vhost: check return of pthread calls") >=20 > Reported-by: Lei Yao > Signed-off-by: Zhiyong Yang Tested-by: Lei Yao This patch can fix the vhost-init issue on my server.=20 > --- > lib/librte_vhost/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 57b86c0..9d2049c 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -668,7 +668,7 @@ rte_vhost_driver_register(const char *path, uint64_t > flags) > } >=20 > vhost_user.vsockets[vhost_user.vsocket_cnt++] =3D vsocket; > - > + goto out; > out_mutex: > if (pthread_mutex_destroy(&vsocket->conn_mutex)) { > RTE_LOG(ERR, VHOST_CONFIG, > -- > 2.9.3