From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EAA601B5E5 for ; Fri, 3 Nov 2017 09:31:29 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2017 01:31:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,337,1505804400"; d="scan'208";a="1213778049" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2017 01:31:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 3 Nov 2017 01:31:27 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Fri, 3 Nov 2017 16:31:25 +0800 From: "Yao, Lei A" To: "Dai, Wei" , "Wu, Jingjing" , "Xing, Beilei" , "Liang, Cunming" CC: "dev@dpdk.org" , "Dai, Wei" Thread-Topic: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power Thread-Index: AQHTVHT5aNZTWYektEawqJa3dqN3XKMCUVIQ Date: Fri, 3 Nov 2017 08:31:25 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A2CE0EC@shsmsx102.ccr.corp.intel.com> References: <1509628256-16300-1-git-send-email-wei.dai@intel.com> <1509693243-43101-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1509693243-43101-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzAwMzdmOWEtMWY2Zi00YmIxLWEyOGQtMWIxY2RmOTNhYjYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlVjc3I4XC9rN2JrRmsxbGxqOTMyQ2JMUW5acUJOS08ycU1ZZUhLaWtCWW1nPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 08:31:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Friday, November 3, 2017 3:14 PM > To: Wu, Jingjing ; Xing, Beilei > ; Liang, Cunming > Cc: dev@dpdk.org; Dai, Wei > Subject: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found = in > l3fwd-power >=20 > These 2 bugs can be observed from example/l3fwd-power run with i40e VF > bound to VFIO-PCI. The test steps are as follows: > 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=3D0, as i40e > VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() fail= ure. > 2. Create a VF from i40e host PF. Let PF run with kernel driver and bind > its VF to VFIO-PCI > 3. Run l3fwd-power like: l3fwd-power -l 18-19 -- -p 0x1 --config=3D'(0,0,= 19)' >=20 > Then, the following error message appears like: > EAL: Error enabling MSI-X interrupts for fd 18 > This error is from rte_intr_enable( )/vfio_enable_msix( ) when enabling > Rx queue interrupt. > Same as the patch 06938770186a ("net/ixgbe: fix VFIO interrupt mapping in > VF"), > to change VFIO MSI-X interrupts mapping, previous mapping should be > cleared > first to avoid above error. >=20 > After fixing above VFIO-PCI MSI-X interrupt mapping. There is still the > following > 2nd bug: l3fwd-power still can not be waked up by incoming packets. >=20 > Same as the patch ca9d6597184b ("net/ixgbe: fix Rx queue interrupt mappin= g > in VF"), > the interrupt vector of Rx queues should be mapped to vector 1 to fix abo= ve > 2nd bug. >=20 > These patches have passed test with l3fwd-power using i40e VF bound to > VFIO-PCI. > They also passed the test with testpmd rxonly and txonly mode with igb_ui= o > and VFIO-PCI. >=20 > Signed-off-by: Wei Dai Tested-by: Lei Yao >=20 > --- > v2: only remap VFIO interrupt in i40evf_dev_start( ) >=20 >=20 > Wei Dai (2): > net/i40e: fix VFIO interrupt mapping in VF > net/i40e: fix Rx queue interrupt mapping in VF >=20 > drivers/net/i40e/i40e_ethdev_vf.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) >=20 > -- > 2.7.4 Following test case is tested and passed with this patch. L3fwd-power with 1 i40e PF (vfio-pci) can receive interrupt L3fwd-power with 1 i40e VF (vfio-pci) can receive interrupt L3fwd-power with 2 i40e VF (vfio-pci) can receive interrupt OS: Ubuntu 16.04 CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz NIC: Ethernet Controller X710