* [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation
@ 2019-04-08 10:13 Pavan Nikhilesh Bhagavatula
2019-04-08 10:13 ` Pavan Nikhilesh Bhagavatula
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-08 10:13 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, thomas; +Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix ether header size calculation in Tx only mode.
Coverity issue: 337684
Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-pmd/txonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index 66e63788a..a9c27be3e 100644
--- a/app/test-pmd/txonly.c
+++ b/app/test-pmd/txonly.c
@@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
/*
* Copy headers in first packet segment(s).
*/
- copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
+ copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt,
sizeof(struct ether_hdr));
if (txonly_multi_flow) {
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation
2019-04-08 10:13 [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation Pavan Nikhilesh Bhagavatula
@ 2019-04-08 10:13 ` Pavan Nikhilesh Bhagavatula
2019-04-08 11:57 ` Bruce Richardson
2019-04-09 9:45 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh Bhagavatula
2 siblings, 0 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-08 10:13 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, thomas; +Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix ether header size calculation in Tx only mode.
Coverity issue: 337684
Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-pmd/txonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index 66e63788a..a9c27be3e 100644
--- a/app/test-pmd/txonly.c
+++ b/app/test-pmd/txonly.c
@@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
/*
* Copy headers in first packet segment(s).
*/
- copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
+ copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt,
sizeof(struct ether_hdr));
if (txonly_multi_flow) {
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation
2019-04-08 10:13 [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation Pavan Nikhilesh Bhagavatula
2019-04-08 10:13 ` Pavan Nikhilesh Bhagavatula
@ 2019-04-08 11:57 ` Bruce Richardson
2019-04-08 11:57 ` Bruce Richardson
2019-04-08 12:28 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-04-09 9:45 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh Bhagavatula
2 siblings, 2 replies; 12+ messages in thread
From: Bruce Richardson @ 2019-04-08 11:57 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula; +Cc: Jerin Jacob Kollanukkaran, thomas, dev
On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix ether header size calculation in Tx only mode.
>
> Coverity issue: 337684
> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> app/test-pmd/txonly.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
> index 66e63788a..a9c27be3e 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
> /*
> * Copy headers in first packet segment(s).
> */
> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
Would a simpler fix not be to change "sizeof(eth_hdr)" to
"sizeof(*eth_hdr)"? It would keep the logical connection between the
destination and destination size, and make future refactoring easier.
/Bruce
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation
2019-04-08 11:57 ` Bruce Richardson
@ 2019-04-08 11:57 ` Bruce Richardson
2019-04-08 12:28 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
1 sibling, 0 replies; 12+ messages in thread
From: Bruce Richardson @ 2019-04-08 11:57 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula; +Cc: Jerin Jacob Kollanukkaran, thomas, dev
On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix ether header size calculation in Tx only mode.
>
> Coverity issue: 337684
> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> app/test-pmd/txonly.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
> index 66e63788a..a9c27be3e 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
> /*
> * Copy headers in first packet segment(s).
> */
> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
Would a simpler fix not be to change "sizeof(eth_hdr)" to
"sizeof(*eth_hdr)"? It would keep the logical connection between the
destination and destination size, and make future refactoring easier.
/Bruce
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [EXT] Re: [PATCH] app/testpmd: fix ether header size calculation
2019-04-08 11:57 ` Bruce Richardson
2019-04-08 11:57 ` Bruce Richardson
@ 2019-04-08 12:28 ` Pavan Nikhilesh Bhagavatula
2019-04-08 12:28 ` Pavan Nikhilesh Bhagavatula
1 sibling, 1 reply; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-08 12:28 UTC (permalink / raw)
To: Bruce Richardson; +Cc: Jerin Jacob Kollanukkaran, thomas, dev
>-----Original Message-----
>From: Bruce Richardson <bruce.richardson@intel.com>
>Sent: Monday, April 8, 2019 5:28 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; thomas@monjalon.net;
>dev@dpdk.org
>Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size
>calculation
>
>External Email
>
>----------------------------------------------------------------------
>On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Fix ether header size calculation in Tx only mode.
>>
>> Coverity issue: 337684
>> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate
>> function")
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> ---
>> app/test-pmd/txonly.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
>> 66e63788a..a9c27be3e 100644
>> --- a/app/test-pmd/txonly.c
>> +++ b/app/test-pmd/txonly.c
>> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct
>rte_mempool *mbp,
>> /*
>> * Copy headers in first packet segment(s).
>> */
>> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
>> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
>
>Would a simpler fix not be to change "sizeof(eth_hdr)" to "sizeof(*eth_hdr)"? It
>would keep the logical connection between the destination and destination size,
>and make future refactoring easier.
>
Ack, will send v2.
>/Bruce
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [EXT] Re: [PATCH] app/testpmd: fix ether header size calculation
2019-04-08 12:28 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
@ 2019-04-08 12:28 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-08 12:28 UTC (permalink / raw)
To: Bruce Richardson; +Cc: Jerin Jacob Kollanukkaran, thomas, dev
>-----Original Message-----
>From: Bruce Richardson <bruce.richardson@intel.com>
>Sent: Monday, April 8, 2019 5:28 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; thomas@monjalon.net;
>dev@dpdk.org
>Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size
>calculation
>
>External Email
>
>----------------------------------------------------------------------
>On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Fix ether header size calculation in Tx only mode.
>>
>> Coverity issue: 337684
>> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate
>> function")
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> ---
>> app/test-pmd/txonly.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
>> 66e63788a..a9c27be3e 100644
>> --- a/app/test-pmd/txonly.c
>> +++ b/app/test-pmd/txonly.c
>> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct
>rte_mempool *mbp,
>> /*
>> * Copy headers in first packet segment(s).
>> */
>> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
>> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
>
>Would a simpler fix not be to change "sizeof(eth_hdr)" to "sizeof(*eth_hdr)"? It
>would keep the logical connection between the destination and destination size,
>and make future refactoring easier.
>
Ack, will send v2.
>/Bruce
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-08 10:13 [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation Pavan Nikhilesh Bhagavatula
2019-04-08 10:13 ` Pavan Nikhilesh Bhagavatula
2019-04-08 11:57 ` Bruce Richardson
@ 2019-04-09 9:45 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:45 ` Pavan Nikhilesh Bhagavatula
2019-04-09 20:59 ` Ferruh Yigit
2 siblings, 2 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-09 9:45 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, xueqin.lin, bruce.richardson, thomas
Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix ether header size calculation in Tx only mode.
Coverity issue: 337684
Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
v2 Changes:
- Preserve relation between destination and destination size. (Bruce)
app/test-pmd/txonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index 66e63788a..2d0e1a027 100644
--- a/app/test-pmd/txonly.c
+++ b/app/test-pmd/txonly.c
@@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
/*
* Copy headers in first packet segment(s).
*/
- copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
+ copy_buf_to_pkt(eth_hdr, sizeof(*eth_hdr), pkt, 0);
copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt,
sizeof(struct ether_hdr));
if (txonly_multi_flow) {
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-09 9:45 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh Bhagavatula
@ 2019-04-09 9:45 ` Pavan Nikhilesh Bhagavatula
2019-04-09 20:59 ` Ferruh Yigit
1 sibling, 0 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-04-09 9:45 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, xueqin.lin, bruce.richardson, thomas
Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix ether header size calculation in Tx only mode.
Coverity issue: 337684
Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
v2 Changes:
- Preserve relation between destination and destination size. (Bruce)
app/test-pmd/txonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index 66e63788a..2d0e1a027 100644
--- a/app/test-pmd/txonly.c
+++ b/app/test-pmd/txonly.c
@@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
/*
* Copy headers in first packet segment(s).
*/
- copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
+ copy_buf_to_pkt(eth_hdr, sizeof(*eth_hdr), pkt, 0);
copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt,
sizeof(struct ether_hdr));
if (txonly_multi_flow) {
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-09 9:45 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh Bhagavatula
2019-04-09 9:45 ` Pavan Nikhilesh Bhagavatula
@ 2019-04-09 20:59 ` Ferruh Yigit
2019-04-09 20:59 ` Ferruh Yigit
2019-04-10 1:23 ` Yao, Lei A
1 sibling, 2 replies; 12+ messages in thread
From: Ferruh Yigit @ 2019-04-09 20:59 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran,
xueqin.lin, bruce.richardson, thomas
Cc: dev, Yao, Lei A, Wang, FengqinX
On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix ether header size calculation in Tx only mode.
>
> Coverity issue: 337684
> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@lei, can you please confirm the txonly mode on next-net?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-09 20:59 ` Ferruh Yigit
@ 2019-04-09 20:59 ` Ferruh Yigit
2019-04-10 1:23 ` Yao, Lei A
1 sibling, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2019-04-09 20:59 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran,
xueqin.lin, bruce.richardson, thomas
Cc: dev, Yao, Lei A, Wang, FengqinX
On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix ether header size calculation in Tx only mode.
>
> Coverity issue: 337684
> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@lei, can you please confirm the txonly mode on next-net?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-09 20:59 ` Ferruh Yigit
2019-04-09 20:59 ` Ferruh Yigit
@ 2019-04-10 1:23 ` Yao, Lei A
2019-04-10 1:23 ` Yao, Lei A
1 sibling, 1 reply; 12+ messages in thread
From: Yao, Lei A @ 2019-04-10 1:23 UTC (permalink / raw)
To: Yigit, Ferruh, Pavan Nikhilesh Bhagavatula,
Jerin Jacob Kollanukkaran, Lin, Xueqin, Richardson, Bruce,
thomas
Cc: dev, Wang, FengqinX
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, April 10, 2019 4:59 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Lin, Xueqin <xueqin.lin@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; Yao, Lei A <lei.a.yao@intel.com>; Wang, FengqinX
> <fengqinx.wang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size
> calculation
>
> On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Fix ether header size calculation in Tx only mode.
> >
> > Coverity issue: 337684
> > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate
> function")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
>
>
> @lei, can you please confirm the txonly mode on next-net?
Hi, Ferruh
The src mac of txonly mode is correct on next-net branch now. Need more
regression test today to check if any other issue exist. Thanks.
BRs
Lei
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation
2019-04-10 1:23 ` Yao, Lei A
@ 2019-04-10 1:23 ` Yao, Lei A
0 siblings, 0 replies; 12+ messages in thread
From: Yao, Lei A @ 2019-04-10 1:23 UTC (permalink / raw)
To: Yigit, Ferruh, Pavan Nikhilesh Bhagavatula,
Jerin Jacob Kollanukkaran, Lin, Xueqin, Richardson, Bruce,
thomas
Cc: dev, Wang, FengqinX
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, April 10, 2019 4:59 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Lin, Xueqin <xueqin.lin@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; Yao, Lei A <lei.a.yao@intel.com>; Wang, FengqinX
> <fengqinx.wang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size
> calculation
>
> On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Fix ether header size calculation in Tx only mode.
> >
> > Coverity issue: 337684
> > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate
> function")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
>
>
> @lei, can you please confirm the txonly mode on next-net?
Hi, Ferruh
The src mac of txonly mode is correct on next-net branch now. Need more
regression test today to check if any other issue exist. Thanks.
BRs
Lei
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-04-10 1:23 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 10:13 [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation Pavan Nikhilesh Bhagavatula
2019-04-08 10:13 ` Pavan Nikhilesh Bhagavatula
2019-04-08 11:57 ` Bruce Richardson
2019-04-08 11:57 ` Bruce Richardson
2019-04-08 12:28 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-04-08 12:28 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:45 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh Bhagavatula
2019-04-09 9:45 ` Pavan Nikhilesh Bhagavatula
2019-04-09 20:59 ` Ferruh Yigit
2019-04-09 20:59 ` Ferruh Yigit
2019-04-10 1:23 ` Yao, Lei A
2019-04-10 1:23 ` Yao, Lei A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).