From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yskoh@mellanox.com>
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr10067.outbound.protection.outlook.com [40.107.1.67])
 by dpdk.org (Postfix) with ESMTP id 4F3C31041
 for <dev@dpdk.org>; Fri, 15 Sep 2017 22:50:23 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=aRssk4rCuH7sSDWgVN9/i07DqujygXNsn9+zc6vLo/k=;
 b=v3HyRRi8+KtsGofFHhZAeY89Pr+8HEEXoCJHvTbHqJNn6E4oZv8gFdQCoXpPrtDHw8NLoLYcs4oXa4iCj7y0u8lxOl5xjDfgS6z3c8YH7RAY8RvIh6oGu7Ss8a9CnyDr+/hlIkjtN0NhGs9hhaslJFBlwwD1uKyvRmD+Stz3vys=
Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by
 VI1PR0501MB3581.eurprd05.prod.outlook.com (10.166.198.14) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
 15.20.56.11; Fri, 15 Sep 2017 20:50:21 +0000
Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com
 ([fe80::7921:ae50:9b96:93ba]) by VI1PR0501MB2045.eurprd05.prod.outlook.com
 ([fe80::7921:ae50:9b96:93ba%14]) with mapi id 15.20.0056.010; Fri, 15 Sep
 2017 20:50:21 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Shachar Beiser <shacharbe@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Adrien Mazarguil
 <adrien.mazarguil@6wind.com>, =?iso-8859-1?Q?N=E9lio_Laranjeiro?=
 <nelio.laranjeiro@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host
 macros
Thread-Index: AQHTLV9vALRq4TV83UeQZNT6gckxT6K2bb0A
Date: Fri, 15 Sep 2017 20:50:21 +0000
Message-ID: <2E023DB0-6B86-4C66-8600-8374A0D95D48@mellanox.com>
References: <f06b61af64939b808f95e166c68326fb5d6c4d83.1504616614.git.shacharbe@mellanox.com>
 <0027cb81572aa683b0db357dbfc62e810f1ae4c8.1505396232.git.shacharbe@mellanox.com>
In-Reply-To: <0027cb81572aa683b0db357dbfc62e810f1ae4c8.1505396232.git.shacharbe@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=yskoh@mellanox.com; 
x-originating-ip: [209.116.155.178]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR0501MB3581;
 6:Tgl0nvJHDkY8vbmyZ1DR4Tcdvt7ClPiXQj0AtDv3lGrhtctC39kUB8oAW6bRrk+6SzjJtYCDxvuYGSTzV55gxtW8tl4MSJSudO+n3929YrN2854nz8Pxt6z/8BrATinEFVNXqWVI8p7RzdnkKwms0moCLIpE+Dgp7lFUCpfNUfn/a+ajxtoESQbUtYgYLsjKfiwmVRi8zfi4LV0DVEwdr5F16PBCjiZJgqasiQ2zgdsyP+Wz1S0vUCTZdcVbwH1CKPcDfc/QGWtzLicmzEmOEdmSyUZQQ/DxKeD0WbTTZ03wGWN/rYuJmjoe/5TdxDJrXhzcbiVNDJt2MHnXPl4d3Q==;
 5:CDZosDHrmYCclRa5HJjD8nZhEtIp/Zwt3HadGIZTDY4l2SdImvbBpZqMHK9gD10p3Y/MdXS/brNcG3HjMsJLgK7DrYflmnJGBUl/sXxansuDvnsCnrf9i7lgq0qdZH+cyHeqnjGOl2NgOxCbuFBIKg==;
 24:y8fyaJOgcFB7G38x0uNCjeK8oVfaNcjTh/rh6eyCyLEemlOag7w9dGR5+mW+KuQUl3JueDYjJL/oW7znTB9e0NRRBrMoQ26gImzF24GoeyQ=;
 7:VtNbA8tTO6ShcXqi2B0mhlB2/kkicHK2vQNk06WWXinyUWpzkWJY9LjZQBehgG7qV6bu8WNxeUftl3Bw4xGRD+tSEdxUBwrCS92Lsp/vPYZm4wXyiiN8oLpYpwPltHZUAMwDYdedv6FJJSRz+U6Xj8AdEb8VPB6Ylw7SlBxhVMkpQM70eiMZyN2APXhHq0xREZ3YsLClpgXObJD96CkQgXynnB3CwOzY8a/AJBCxoOg=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-ms-office365-filtering-correlation-id: c3eb374a-1a59-4c3a-df79-08d4fc7b61cb
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);
 SRVR:VI1PR0501MB3581; 
x-ms-traffictypediagnostic: VI1PR0501MB3581:
x-exchange-antispam-report-test: UriScan:(788757137089);
x-microsoft-antispam-prvs: <VI1PR0501MB3581DBD72481863FDC0E730EC36C0@VI1PR0501MB3581.eurprd05.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
 SRVR:VI1PR0501MB3581; BCL:0; PCL:0;
 RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
 SRVR:VI1PR0501MB3581; 
x-forefront-prvs: 0431F981D8
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(6009001)(376002)(346002)(39860400002)(377454003)(199003)(24454002)(189002)(6506006)(54906002)(6436002)(83716003)(189998001)(6512007)(229853002)(5660300001)(68736007)(6862004)(106356001)(99286003)(105586002)(6486002)(8936002)(4326008)(2950100002)(81156014)(110136004)(316002)(81166006)(53936002)(8676002)(36756003)(7736002)(6246003)(6636002)(305945005)(3660700001)(53546010)(101416001)(478600001)(25786009)(2900100001)(5250100002)(86362001)(97736004)(33656002)(82746002)(3280700002)(102836003)(6116002)(3846002)(76176999)(54356999)(50986999)(37006003)(66066001)(2906002)(14454004);
 DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB3581;
 H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
 A:1; MX:1; LANG:en; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <8F5C5130648C264C8015A1A50FD40906@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2017 20:50:21.7072 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB3581
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host
 macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 20:50:23 -0000


> On Sep 14, 2017, at 6:43 AM, Shachar Beiser <shacharbe@mellanox.com> wrot=
e:
>=20
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
[...]
> @@ -550,7 +553,8 @@
> 				max_wqe -=3D n;
> 				if (tso) {
> 					uint32_t inl =3D
> -						htonl(copy_b | MLX5_INLINE_SEG);
> +					rte_cpu_to_be_32(copy_b |
> +							 MLX5_INLINE_SEG);
Wrong indentation.

[...]
> @@ -605,8 +605,8 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *, uint16_=
t, uint16_t, unsigned int,
> 	uint64_t *dst =3D (uint64_t *)((uintptr_t)txq->bf_reg);
> 	volatile uint64_t *src =3D ((volatile uint64_t *)wqe);
>=20
> -	rte_io_wmb();
> -	*txq->qp_db =3D htonl(txq->wqe_ci);
> +	rte_wmb();
Look like a mistake when rebasing. This should not be touched by this patch=
.

> +	*txq->qp_db =3D rte_cpu_to_be_32(txq->wqe_ci);
> 	/* Ensure ordering between DB record and BF copy. */
> 	rte_wmb();
> 	*dst =3D *src;

--
Thanks,
Yongseok