From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0069.outbound.protection.outlook.com [104.47.0.69]) by dpdk.org (Postfix) with ESMTP id 272171B8F0 for ; Thu, 10 May 2018 08:01:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CUfFi5GWcss0/Qs7IozdvCnuC1Xv0avOYF0e7gOtpjM=; b=UEChc0URWg76tYpJFILYmJkFHc9hWlRlURnDDqfdTdw1m8kiTuF/WdQfwOFLUb2Lq/aLB+yro/lLMWi33gY9GfnPhfPTvZqiaS32urlOY1Dyq1y6o9an2K/89PCpu2RPzKqweq+MgKanbr8MNkW256soWseKisYT8VTmSBOm5/8= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2270.eurprd05.prod.outlook.com (10.169.135.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Thu, 10 May 2018 06:01:50 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0755.012; Thu, 10 May 2018 06:01:49 +0000 From: Yongseok Koh To: Ferruh Yigit CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support Thread-Index: AQHT6CRiA4tkbPd26E+qrKUDuybEog== Date: Thu, 10 May 2018 06:01:49 +0000 Message-ID: <2F032BAA-5743-4DA6-96B6-BBDFDCE0CF69@mellanox.com> References: <20180502231654.7596-1-yskoh@mellanox.com> <20180509110906.19462-1-yskoh@mellanox.com> <20180509110906.19462-5-yskoh@mellanox.com> <274843e9-ed82-9576-baf8-a704babf64c5@intel.com> <2DDD3185-6284-4BA3-A187-AED4C96407EB@mellanox.com> In-Reply-To: <2DDD3185-6284-4BA3-A187-AED4C96407EB@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2270; 7:JinsPfAdi/tTq3qqno+zZp22gKve5FuyZOSZnmU7Q2WxniSsu63s4y5hPbj/0y/DWC4udT/PMPDT6dqmncE2HpRa7kUfkupBe3Jzaonz4GdeqtI3u79EKVgtXE9AsCeuERKsDmL0CHjdQfQEdDaIkkS28/+PaurtHnpIW7usBvJlIjaHbKDLJvwErAsaCgX1qWXfLFvthQvF1Ii8HIsSBOHF7xYJjofaTr19Sfy7WMUJy4vSgvsgVYVGIkjqxUKT x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2270; x-ms-traffictypediagnostic: VI1PR0501MB2270: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR0501MB2270; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2270; x-forefront-prvs: 066898046A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(376002)(39860400002)(39380400002)(189003)(199004)(6306002)(229853002)(6116002)(478600001)(316002)(76176011)(6506007)(2900100001)(53546011)(81156014)(82746002)(93886005)(33656002)(5660300001)(3846002)(8936002)(81166006)(102836004)(14454004)(6512007)(26005)(7736002)(4326008)(59450400001)(99286004)(486006)(6486002)(6916009)(53936002)(6246003)(53376002)(476003)(11346002)(446003)(66066001)(86362001)(106356001)(966005)(68736007)(305945005)(5250100002)(2616005)(36756003)(186003)(97736004)(6436002)(105586002)(3660700001)(575784001)(2906002)(83716003)(54906003)(25786009)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2270; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: P68dFFQjUGLgvWheLol2Knqyu6/JKV1rpx6oFboTuGc+rCenztpjzWqLUim8xLGgJ3FaEhvfZzl2ZJMVrGCVEPpr8SqV1XZymGdzPs+0cS7BBA6MO2TmeaxykeNAV0FvgWz1QHRnaVikRUTAeaJ7jF3Tkjqrzx8EF6yhBKZJ3biiJkI0ZXYF8rC3ATsKLuhv spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <4587578C8A793F42AC5D87998B11066A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1cac4a58-22b9-4221-4819-08d5b63b8557 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cac4a58-22b9-4221-4819-08d5b63b8557 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2018 06:01:49.7646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2270 Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 06:01:52 -0000 > On May 9, 2018, at 8:00 PM, Yongseok Koh wrote: >=20 >=20 >> On May 9, 2018, at 4:12 PM, Ferruh Yigit wrote: >>=20 >> On 5/9/2018 12:09 PM, Yongseok Koh wrote: >> <...> >>=20 >>> +/** >>> + * Insert an entry to B-tree lookup table. >>> + * >>> + * @param bt >>> + * Pointer to B-tree structure. >>> + * @param entry >>> + * Pointer to new entry to insert. >>> + * >>> + * @return >>> + * 0 on success, -1 on failure. >>> + */ >>> +static int >>> +mr_btree_insert(struct mlx4_mr_btree *bt, struct mlx4_mr_cache *entry) >>> +{ >>> + struct mlx4_mr_cache *lkp_tbl; >>> + uint16_t idx =3D 0; >>> + size_t shift; >>> + >>> + assert(bt !=3D NULL); >>> + assert(bt->len <=3D bt->size); >>> + assert(bt->len > 0); >>> + lkp_tbl =3D *bt->table; >>> + /* Find out the slot for insertion. */ >>> + if (mr_btree_lookup(bt, &idx, entry->start) !=3D UINT32_MAX) { >>> + DEBUG("abort insertion to B-tree(%p):" >>> + " already exist at idx=3D%u [0x%lx, 0x%lx) lkey=3D0x%x", >>> + (void *)bt, idx, entry->start, entry->end, entry->lkey); >>=20 >> This and various other logs causing 32bits build error because of %lx us= age. Can >> you please check them? >>=20 >> I am feeling sad to complain a patch like this just because of log forma= t issue, >> we should find a solution to this issue as community, either checkpatch = checks >> or automated 32bit builds, I don't know. >=20 > Bummer. I have to change my bad habit of using %lx. And we will add 32-bi= t build > check to our internal system to filter this kind of mistakes beforehand. >=20 > Will work with Shahaf to fix it and rebase next-net-mlx. Ferruh, I've sent out a patch to Shahaf to change printing format specifier= s and Shahaf will squash it into the previous patches. However, it seems we had stopped supporting 32-bit compilation since Nelio'= s commit [1] Not sure I'm doing right but I'm compiling it for T=3Di686-native-linuxapp-= gcc and still having a few more errors even except for my code. And even if I fix a= ll of the errors, linkage fails as explained in the commit message of [1]. Are you sure you encountered this 32b compilation issue for the first time? [1] http://dpdk.org/browse/dpdk/commit/?id=3Debbb81eb27daca0a89ee8f228fcf14= 1d9eb6ef1c Thanks, Yongseok