From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5488511C5 for ; Mon, 13 May 2019 11:51:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 02:51:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,465,1549958400"; d="scan'208";a="171134619" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 13 May 2019 02:51:28 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 13 May 2019 02:51:28 -0700 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 13 May 2019 02:51:28 -0700 Received: from HASMSX110.ger.corp.intel.com ([169.254.6.92]) by hasmsx108.ger.corp.intel.com ([169.254.9.163]) with mapi id 14.03.0415.000; Mon, 13 May 2019 12:51:25 +0300 From: "Smoczynski, MarcinX" To: Thomas Monjalon , "dev@dpdk.org" CC: "Richardson, Bruce" , "Ananyev, Konstantin" , "shahafs@mellanox.com" , "gaetan.rivet@6wind.com" , "adrien.mazarguil@6wind.com" , "matan@mellanox.com" Thread-Topic: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD Thread-Index: AdUHUhFuf1vcUQd1TgeecdbKRnBo9f//4sQAgAAB2gD/+6jjcA== Date: Mon, 13 May 2019 09:51:24 +0000 Message-ID: <2F25558C1648FA498380EAC12A86126251F3B2@HASMSX110.ger.corp.intel.com> References: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> <9076832.UKkv39EgZr@xps> <2604468.nBFxeWxGDx@xps> In-Reply-To: <2604468.nBFxeWxGDx@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWUwZmY4ODctYTdjYi00ZmE2LWE4NTUtOWM2YTVhYjhmMjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOCttUDV2UkR6bW5yV1wvODNlZjB6am5hM2dKbUtXRlR4UFRWU3k0TVBnNnFkOWJyK280YzZiTjllN1NkUDhzKzEifQ== x-originating-ip: [10.104.116.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 09:51:30 -0000 10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD=20 > > when using XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome=20 > > this situation we can either remove problematic XOPEN macros from=20 > > mk/meson rules (drivers/net/failsafe, drivers/net/mlx4,=20 > > drivers/net/mlx5) >=20 > What is the consequence of removing these macros in mlx and failsafe PMDs= ? The purpose of these *_SOURCE constants is to enable particular feature set= s visibility. As long as we have GNU_SOURCE on Linux removing it won't have a= ny consequences. On BSD it will unify feature sets visibility with the rest of sources. Can't think of any downsides here. I believe XOPEN_SOURCE was introduced to extend features not to restrict th= em. MS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A1210A00E6 for ; Mon, 13 May 2019 11:51:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6125E2BC1; Mon, 13 May 2019 11:51:32 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5488511C5 for ; Mon, 13 May 2019 11:51:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 02:51:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,465,1549958400"; d="scan'208";a="171134619" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 13 May 2019 02:51:28 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 13 May 2019 02:51:28 -0700 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 13 May 2019 02:51:28 -0700 Received: from HASMSX110.ger.corp.intel.com ([169.254.6.92]) by hasmsx108.ger.corp.intel.com ([169.254.9.163]) with mapi id 14.03.0415.000; Mon, 13 May 2019 12:51:25 +0300 From: "Smoczynski, MarcinX" To: Thomas Monjalon , "dev@dpdk.org" CC: "Richardson, Bruce" , "Ananyev, Konstantin" , "shahafs@mellanox.com" , "gaetan.rivet@6wind.com" , "adrien.mazarguil@6wind.com" , "matan@mellanox.com" Thread-Topic: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD Thread-Index: AdUHUhFuf1vcUQd1TgeecdbKRnBo9f//4sQAgAAB2gD/+6jjcA== Date: Mon, 13 May 2019 09:51:24 +0000 Message-ID: <2F25558C1648FA498380EAC12A86126251F3B2@HASMSX110.ger.corp.intel.com> References: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> <9076832.UKkv39EgZr@xps> <2604468.nBFxeWxGDx@xps> In-Reply-To: <2604468.nBFxeWxGDx@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWUwZmY4ODctYTdjYi00ZmE2LWE4NTUtOWM2YTVhYjhmMjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOCttUDV2UkR6bW5yV1wvODNlZjB6am5hM2dKbUtXRlR4UFRWU3k0TVBnNnFkOWJyK280YzZiTjllN1NkUDhzKzEifQ== x-originating-ip: [10.104.116.165] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513095124.rqkB1ofBgZgjzBO13cLlh_NmZPMVFCJc7eRFTVbWkBc@z> 10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD=20 > > when using XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome=20 > > this situation we can either remove problematic XOPEN macros from=20 > > mk/meson rules (drivers/net/failsafe, drivers/net/mlx4,=20 > > drivers/net/mlx5) >=20 > What is the consequence of removing these macros in mlx and failsafe PMDs= ? The purpose of these *_SOURCE constants is to enable particular feature set= s visibility. As long as we have GNU_SOURCE on Linux removing it won't have a= ny consequences. On BSD it will unify feature sets visibility with the rest of sources. Can't think of any downsides here. I believe XOPEN_SOURCE was introduced to extend features not to restrict th= em. MS