From: Andrew Rybchenko <arybchenko@solarflare.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
"John McNamara" <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"Gaetan Rivet" <grive@u256.net>
Subject: Re: [dpdk-dev] [PATCH v2 3/6] pci: move resource mapping to the PCI bus
Date: Mon, 14 Sep 2020 13:22:13 +0300 [thread overview]
Message-ID: <2a395299-ce0f-c990-5fb5-0ac936e762f5@solarflare.com> (raw)
In-Reply-To: <20200914082350.13279-4-david.marchand@redhat.com>
On 9/14/20 11:23 AM, David Marchand wrote:
> As reported during 20.08 work for Windows, the pci_map_resource API was
> built with the assumption that its flags would be passed to mmap().
>
> This introduced a regression when adding the rte_mem_map API as reported
> in the workaround commit 9d2b24593724 ("pci: keep API compatibility with
> mmap values").
>
> This API was only used in the PCI bus code, so move it there.
> With this move, there is no other user so no ambiguity anymore: the
> passed additional flags are documented as rte_mem_map API flags.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2020-09-14 10:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:17 [dpdk-dev] [PATCH 0/5] 20.11 announced cleanups David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 1/5] bus/pci: switch to private kernel driver enum David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 2/5] pci: move resource mapping to the PCI bus David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 3/5] mem: drop mapping API workaround David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 4/5] eal: hide internal device event structure David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 5/5] bus/pci: remove duplicate declaration David Marchand
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 0/6] 20.11 announced cleanups David Marchand
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 1/6] ethdev: remove unused kernel driver field David Marchand
2020-09-14 10:14 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 2/6] bus/pci: switch to private kernel driver enum David Marchand
2020-09-14 10:19 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 3/6] pci: move resource mapping to the PCI bus David Marchand
2020-09-14 10:22 ` Andrew Rybchenko [this message]
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 4/6] mem: drop mapping API workaround David Marchand
2020-09-14 10:22 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 5/6] eal: hide internal device event structure David Marchand
2020-09-18 14:56 ` Kinsella, Ray
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 6/6] bus/pci: remove duplicate declaration David Marchand
2020-09-14 10:24 ` Andrew Rybchenko
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 0/6] 20.11 announced cleanups David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 1/6] ethdev: remove unused kernel driver field David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 2/6] bus/pci: switch to private kernel driver enum David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 3/6] pci: move resource mapping to the PCI bus David Marchand
2020-09-18 13:43 ` Kinsella, Ray
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 4/6] mem: drop mapping API workaround David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure David Marchand
2020-09-18 3:40 ` Guo, Jia
2020-09-18 13:36 ` Kinsella, Ray
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 6/6] bus/pci: remove duplicate declaration David Marchand
2020-09-21 9:05 ` [dpdk-dev] [PATCH v3 0/6] 20.11 announced cleanups David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a395299-ce0f-c990-5fb5-0ac936e762f5@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=grive@u256.net \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).