From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B133CA04B5; Wed, 13 Jan 2021 12:08:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DDB6140CFC; Wed, 13 Jan 2021 12:08:51 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 6B4A1140CF6; Wed, 13 Jan 2021 12:08:49 +0100 (CET) IronPort-SDR: YM3uj4O1TvKQF3hmys5VEdvSW/vUr++Y1u7m+W3RHE4xnHKGAfnAPnPdyduCuThkbJhphw3OYD VChN/OdfIaLw== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="196823726" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="196823726" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:08:48 -0800 IronPort-SDR: MDAOhjH8igtVvfe+inOMwQ91NKLG5hHKIHFz8ofQobiZPNuOXLsV7i1F7rJPNSuflQ4bwKSo6p tK6FNcWpVLbg== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="381805202" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.253.108]) ([10.213.253.108]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:08:47 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org References: <20201217113656.28884-1-david.hunt@intel.com> <20210108143048.23755-1-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <2a4c607c-8919-7572-0646-c9627e6cbe48@intel.com> Date: Wed, 13 Jan 2021 11:08:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210108143048.23755-1-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/6] power: fix make build for power apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08-Jan-21 2:30 PM, David Hunt wrote: > The power example applications that uses the virtio-serial method of > communication cannot currently be built with make, and can only be built > using meson/ninja. > > The guest channel message definitions and functions in guest_channel.h > are needed by applications and need to be made public. > > This worked pre-20.11, but now with all the meson/ninja changes, making > these apps externally no longer works. To fix, we need to move the header > file with the API definitions for the channel commands public, and rename > the functions accordingly. > > The main change is to rename channel_commands.h to > rte_power_guest_channel.h so that it gets picked up by the installer and > copied to /usr/local/include. Other changes include renaming #defines to > have RTE_ at the beginning instead of CPU_. Finally we refactor the code > to work with those changes. > > --- > v2 changes > - re-worked from monolithic patch to a 6 patch patchset for easier review > > [PATCH v2 1/6] power: create guest channel public header file > [PATCH v2 2/6] power: make channel msg functions public > [PATCH v2 3/6] power: rename public structs > [PATCH v2 4/6] power: rename defines > [PATCH v2 5/6] power: add new header file to export list > [PATCH v2 6/6] power: clean up includes > Just a general question: wouldn't it be better to move this stuff entirely into sample app and not bother with keeping it in the library? There is precedent - ethtool app has a "library" and an "application" part, i think you should be able to move it out of the library and into the sample app entirely without too much trouble, as code looks to be fairly self-contained. -- Thanks, Anatoly