From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27B77A0A01; Mon, 4 Jan 2021 13:44:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93A45160707; Mon, 4 Jan 2021 13:44:46 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 6663E1606F8 for ; Mon, 4 Jan 2021 13:44:45 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 104CUFQQ030437; Mon, 4 Jan 2021 04:44:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=/HF5S5LVANH7tbTeVZAOlSmwr0aAcywuR9TfL5n8zPQ=; b=PRStaJlcJL2BuCtgEoPYv21jtgeMVVCzOZndCGHlZlsfAPpAJN7ANcJYTB8Zr9Fd2Gk+ HnDo6AxDMq9QHvVCt2CDWW7V/Qz26VufDKEQ2tQJl/dFLbO2m8X3qBTtOv6vL0sjjseN FmJFSz/JmAnobaKl/SUv0pzXJ7xqMqy0RW0XlhAaqLMUqgPWxQGgL5opE/dijo3WsNeU kvygam3ouEByJrT01wSpXV83aYgs/LUJMrqoZYfc3R4rqE3fGHTJnK/2O6u9Jk4xSpUY 0vSP7JuM35Mt15ct3dfQxKv1SpE6jmzYe6/8oROHLQsjNbWP0Ecy+GJ639v6gzuXNS8d zw== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com with ESMTP id 35tq2ubcv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 04 Jan 2021 04:44:44 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 Jan 2021 04:44:43 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 Jan 2021 04:44:42 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 4 Jan 2021 04:44:42 -0800 Received: from [10.193.38.82] (unknown [10.193.38.82]) by maili.marvell.com (Postfix) with ESMTP id F19FE3F703F; Mon, 4 Jan 2021 04:44:41 -0800 (PST) To: Balazs Nemeth , , Devendra Singh Rawat References: From: Igor Russkikh Message-ID: <2a4ca79e-8051-c0c2-8bea-a0f972a69d8e@marvell.com> Date: Mon, 4 Jan 2021 13:44:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Thunderbird/85.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-04_07:2021-01-04, 2021-01-04 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > When calling rte_eth_promiscuous_enable(port_id) followed by > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode > anymore. This patch ensures that promisc mode takes precedence over > allmulticast mode fixing the regression introduced by b10231aed1ed. > > Signed-off-by: Balazs Nemeth > --- > drivers/net/qede/qede_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/qede/qede_ethdev.c > b/drivers/net/qede/qede_ethdev.c > index 549013557..3bec62d82 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct > rte_eth_dev *eth_dev) > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; > enum _ecore_status_t ecore_status; > > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1) > + type = QED_FILTER_RX_MODE_TYPE_PROMISC; > ecore_status = qed_configure_filter_rx_mode(eth_dev, type); > > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; Hi Balazs, thanks for posting! I think we need Fixes tag here. Devendra, could you please check if thats enough? May be we should consider more of internal states here? What if we'll do promisc_disable() after that? Will allmulti state persist? Igor