From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0057.outbound.protection.outlook.com [104.47.33.57]) by dpdk.org (Postfix) with ESMTP id 7E0771B01F for ; Wed, 10 Jan 2018 13:49:18 +0100 (CET) Received: from BN6PR03CA0091.namprd03.prod.outlook.com (10.164.122.157) by CY4PR03MB2695.namprd03.prod.outlook.com (10.173.43.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 12:49:17 +0000 Received: from BY2FFO11FD019.protection.gbl (2a01:111:f400:7c0c::170) by BN6PR03CA0091.outlook.office365.com (2603:10b6:405:6f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Wed, 10 Jan 2018 12:49:17 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD019.mail.protection.outlook.com (10.1.14.107) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Wed, 10 Jan 2018 12:48:44 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0ACnCh8024817; Wed, 10 Jan 2018 05:49:13 -0700 To: Olivier MATZ References: <1499170968-23016-1-git-send-email-hemant.agrawal@nxp.com> <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1513333483-4372-2-git-send-email-hemant.agrawal@nxp.com> <20171218085507.GA20578@jerin> <85485fb0-f602-78af-c40a-7bfb4bda561e@nxp.com> <20171222145957.tc56hzyzbxj65rg5@platinum> <64ba944d-a31e-a42f-1d9e-619dbeef59fe@nxp.com> CC: Jerin Jacob , , From: Hemant Agrawal Message-ID: <2a6099ab-29fe-e9c4-3eec-4f71444896ba@nxp.com> Date: Wed, 10 Jan 2018 18:19:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <64ba944d-a31e-a42f-1d9e-619dbeef59fe@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131600621253891355; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(346002)(39380400002)(396003)(376002)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(305945005)(86362001)(8676002)(54906003)(83506002)(68736007)(106466001)(58126008)(356003)(8936002)(105606002)(230700001)(23746002)(316002)(77096006)(6346003)(31696002)(81166006)(53936002)(31686004)(498600001)(81156014)(2950100002)(2906002)(4326008)(67846002)(6246003)(64126003)(65826007)(65956001)(76176011)(6916009)(50466002)(93886005)(97736004)(47776003)(229853002)(5660300001)(65806001)(36756003)(104016004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2695; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD019; 1:IDopSW0tKyotGGXpePL0A+jHe5wp/0K6PCC/EpEs97fDP948M43ZxrzmOVj42DM9U/Ln/37MQW/UNOABlCUKwPBgVG23DTi2DyzlNvmWBg+PqV5Ydc1YnbvZHu02rqc7 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fde8c606-c6f0-4758-151b-08d558287c86 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020051)(5600026)(4604075)(2017052603307); SRVR:CY4PR03MB2695; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 3:EIS6gydcjNco5NCZEVta3qJco7IY8ELswlQ8qZHWqq9MWv3KxRjZgZRpimZr7p2/Q4K7CAlitikYFdtn46buX4LNU8SaOES929rcS6mRkWXZeUVDqUfd92foYCbRTO+KRIF8IS71dEwNMTzcwmvJqW1FA6P4uW5a/o6jZxkVC0J2QQVCb/W+PY3dJtN7gxqxvRD/MNAhY+3sCW1kwAStCCW1L/v3x64lEoKF1skwb1vlAY1COzrS/jBOnh62X78Im3k5am6JSv1Oti3XJ4n2q5Dbsfgz92rZEVn06+lnkVvWt+VCHKQEG8uIBSekJZ0Wk0ayzMKiXm9OmFgMtVl0wJ5d91CYnuKT2V72LBIwlZI=; 25:G6BBq+tbBRMLeScsHDZkgXHIa4WZXXGHkHByXT30qfFyrud7rEVWSI9JHtaakU17CFlg9Jn/UXR2ilafHfEi+TX9F3saDy6fWyO8U1PFtl3ei0sRmF+lw+73u66pGZ/v+nGyUSStv1f1VjAnHNEOusj1b7cuJlbvTPAtNrbWAV9kmh+eRcUD9FNIvsHlrEO4ZUgIN4531YN52JTou2SvPnBeppWFTpH9IZ+3QNYuwSBaVW7LF7FjNs7IFtadZAUQgZBwwxnbtvvvO9PGlGbYIczIq/wv51LB3I6IPExSK0zYPVSdTSurUjVrpG96D5ny5YDf6pdjSChaKr7YE/3+rw== X-MS-TrafficTypeDiagnostic: CY4PR03MB2695: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 31:VweTHDjsXwKai0463wVcKqj1Gh4j1tzCxo08N5pK7lN7DgjGz9tlwsszk0KK17W1gDv/vYOjMDhYGBLVfs27Xh3gTR793b9E5Q50Q37ZRWIWDR/Hw3Dq55Zvcce9zlVI7a5NzC4eOxJZoxZE0tbO5ZgBJ6ddyHqNycEXiW7xeZ8/hDLPFdrBz3KdTL5mmt3kN/lUBJpIf+k9nRdrc2KxJ7Gr9t/rkNmnH+off6PciJU=; 4:9Uy9LH5PpZcNy9NdQSkTXnjIXthh0FLt+DmdfkNee0EDaybViLb105gyYC5/1z1Ij3MHpyOrgFAbK56Zbr6i07opwEm305MAgs4IKA+p4MsTEj7MV0M+L4TYxZzZj/IzcDwQTQ+ylAQgnc4lP8lPSOfOwccPEfAsMrgjZ9cEAZ5Jino7aiqyBe3R/tsyCJe8grH7W+TFAzUDalVI+gHPIEZJxqKX/XIJD2gfrUMueJk47ISQI/MVZFhBLc91GcMFS4aD6PqIk3mKA2eF/GXsyg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3231023)(944501119)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123556025)(20161123559100)(20161123563025)(20161123565025)(201708071742011); SRVR:CY4PR03MB2695; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY4PR03MB2695; X-Forefront-PRVS: 0548586081 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2695; 23:jeaQwmqe5WAQhlibWPsimBZRyu92tg4Z/0v0r?= =?Windows-1252?Q?rcDq6e9fv8jwrONU6G8ZeBuDXJqDKtXZLB6wUM+fDL4RNWTWveJlCI3Y?= =?Windows-1252?Q?T7gyPmzFvnz3kTqZ5ceC2IWPs9NLQw9L5S4aC9Xj796G6Wde3XDFT4KI?= =?Windows-1252?Q?EqWqZ0H1dWvk4KBfR9KmTtHPMKmjlF2dBvkJOJ0RIouSslGzCt6Cglyw?= =?Windows-1252?Q?xHI+UcYhx6tcPum2eIAbmt/7mvi4LTrU22eneaiQXi1cXO0ZEfFfvsU7?= =?Windows-1252?Q?fsu477ocuw8/CYgQeEJroxO42N6u4Nbql7jA9/RDJpQ3owKJYjI//p/P?= =?Windows-1252?Q?4KeWkX0BJ5IOEHQplVTNfXvAXRW0OUFZD9TBkzM4nZEB7plc1HFjdUR7?= =?Windows-1252?Q?OubFu2dvU1AYl66g0sYaEJfJt19PnBYxJ9wlXO5j7rHm6dmY85KS0q3V?= =?Windows-1252?Q?l2OLXVwnhYQYeTUaIUz6N457Y4cyS14zLXNK96772QAfADA+jmrNzXt5?= =?Windows-1252?Q?QqeByj2LF+kqtKvXbHSsLVDq6XaI/feGCu9rai/NMXT6SaHsjYMtDeKQ?= =?Windows-1252?Q?oESwqHxm+q+rJKOyg5/gsCW5qqdQgr7ks5PqQAUY2lSpeHOYhCNbs06t?= =?Windows-1252?Q?WE8XyiUV5Cq8bCdBDrqY76UBUI3/gVBGod2D77/n839yq8zzXJikGRwF?= =?Windows-1252?Q?yESJsYFFhIl6r5q9rFEG5v1q+WTsFg5KqQnar5+S1rbRqY/S7hhqkYq3?= =?Windows-1252?Q?zSX6/NFOKiZEvsNjNiHz1rD+LK6grq9jPhd0ETRo79C3hpvM1/EEypiH?= =?Windows-1252?Q?qiyQjaHUr19zX/jhU/CaouvRSmKdS3lxxhOS9NEo+BacAF9l+gHeXAaR?= =?Windows-1252?Q?CByDslL+EKwge4hUKjODa39khOZgfXP9he2ogEh/Pjj9UVp1Mm3BLwMI?= =?Windows-1252?Q?PcXYgsMEcqrZwWUS5w7xWQQPj9/fJfm0BYHX0XynV/sPfazS752YSyfC?= =?Windows-1252?Q?aycVkMUqQkYrdFWLTA7X5hetD7tiacXRHfuLiqoaxSAq878mySa1krJB?= =?Windows-1252?Q?YIgy2dD7mQ7cS1b92OtBgPTK834wQ1Miv98uzaJ/y2yjdT0nzYXRDEma?= =?Windows-1252?Q?QZwZEG7VE3cqJxGXYMRuEDoLWFBfBqWVkhBMOy7GIGr05NYzGKfhQo5L?= =?Windows-1252?Q?Ok4Fhj6aCsiqiUnFlbsfb4130RANym1L3wwuGckC2C4rnxVx+Wb9Sn/p?= =?Windows-1252?Q?HzjPpdM7GiuagEI5yX/XK094K4TQOoCdwWrx9EiUR4Xt4sn44cJa0Dtb?= =?Windows-1252?Q?6MX1SaiEtF3+rwIBRdfG/OwXA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 6:Ri4Nyv70lvzzcJPhy03TPj8sWxdZyHWI7EEzZidJop1Gsz7xSUFdASm39UFQ6A4kExK7L51HETfHxx38cvjevU4jXXCn4QZGd5YX2p/H8d7I4iqSW+XPX2MKnKXDfGmvC8VPp7+pjvaEs+HPP8UUv39a4apROHpZuyBv+wEixmrWs2QaMdBWnY1T06uBM5cwXYz3i51lwHIj2oRzIfbgziPzKS0ZIr1b9HgSQgRPSrVMa9FkM8YGVHsM6hDa8eWbv1FJGER1w8gaOXtKdOEzG0EX5dU8qWJC1EAKgkEygOOBWunMXH3DbyM361dc3X9XF3nv5jgZV/Gy/xzin8jHB1TMR+p5JxkYAz3TS7qYiSw=; 5:+6gvNhN5h1czm+bLXZEB8llNRXmx+7Eh9pfZ0bMypxEUr0JbpMYO/UNSCPewbwwMkSyF2wzLbofJaEIpLBeLnCP9+P80dCFX+HclY0wLopmOOkC2LoqJTUze/L2mXXWs1KNZByVPJGoR1m4+6ATg7DGz0+T8eH4+J80UkoOWgNM=; 24:pzPyFkAfxb6XlWgvK9DdA/mUbHLN7dX/wKtimL5omuZb+xQuoCrwWNM8D7oUp23cHAH3qzbfqXLvra/cMKlaXWIJv9rSfhKBES8rp3rqvmA=; 7:ffBkJFOxquVG20gmexsilSgmNjySOM2SkRCVU52cjvNwKtUucZTmsC0KfzfqzhOHGMTguP2HDgLpzWwyLIRl799YIS0WskN8DNf5KJ9HHOuCMF5tkcLbE5jBP7NqouqtrQHA47cIbIgtiO0d9S1eDRIZJgrQfe0o9R8qoJ6SOFi0dfAcI9HZ8tbSXUKLTJiHFMla184yDuVL3YqD3Rjb2szDKFq+Wh7+yxe2E/w/ixcGiryFYjlyrE4xWDZg1k9N SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 12:48:44.9367 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fde8c606-c6f0-4758-151b-08d558287c86 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2695 Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 12:49:19 -0000 Hi Olivier, >> I just feel it's a bit messy to have: >> >> - rte_eal_mbuf_default_mempool_ops() in eal API >> return user-selected ops if any, or compile-time default >> >> - rte_pktmbuf_active_mempool_ops() in mbuf API >> return platform ops except if a selected user ops != compile default >> >> Thomas suggested somewhere (but I don't remember in which thread) to have >> rte_eal_mbuf_default_mempool_ops() in mbuf code, and I think he was >> right. >> > > The idea is good. It will break ABI, but we can move around in > systematic way. > >> I think the whole mbuf pool ops selection mechanism should be at the >> same place. I could be in a specific file of librte_mbuf. >> I have just tried to implement your suggestions. I need one clarification. Eal based internal config is being used to store the command line mempool_ops_name. If we want it to be a mbuf based API (instead of eal_mbuf), we need to export internal_config via map file for shared build. Are you fine with that? If not, we have to live with eal_mbuf APIs only. Regards, Hemant