DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t
Date: Mon, 18 Sep 2017 15:06:10 +0100	[thread overview]
Message-ID: <2a655cea-340a-1b7a-d0ba-01db39dbcd24@intel.com> (raw)
In-Reply-To: <20170814151537.29454-2-santosh.shukla@caviumnetworks.com>

Hi Santosh,

On 14-Aug-17 4:15 PM, Santosh Shukla wrote:
> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> ---
> v1 note:
> - As changes percolate to all possible dpdk subsystem..
>    so its difficult to tag subject with one common title,
>    but since, core of changeset is at eal layer so keeping 'eal:'
>    as title.
> 
>   app/test-crypto-perf/cperf_test_vectors.h          |  4 +--
>   doc/guides/contributing/documentation.rst          |  4 +--
>   doc/guides/prog_guide/cryptodev_lib.rst            |  6 ++--
>   drivers/bus/fslmc/portal/dpaa2_hw_pvt.h            | 14 ++++----
>   drivers/crypto/qat/qat_adf/qat_algs.h              |  6 ++--
>   drivers/crypto/qat/qat_crypto.h                    |  2 +-
>   drivers/mempool/dpaa2/dpaa2_hw_mempool.h           |  2 +-
>   drivers/net/ark/ark_ddm.c                          |  2 +-
>   drivers/net/ark/ark_ddm.h                          |  4 +--
>   drivers/net/ark/ark_ethdev_rx.c                    | 12 +++----
>   drivers/net/ark/ark_ethdev_tx.c                    |  2 +-
>   drivers/net/ark/ark_mpu.c                          |  2 +-
>   drivers/net/ark/ark_mpu.h                          |  4 +--
>   drivers/net/ark/ark_udm.c                          |  2 +-
>   drivers/net/ark/ark_udm.h                          |  4 +--
>   drivers/net/avp/avp_ethdev.c                       |  2 +-
>   drivers/net/avp/rte_avp_common.h                   | 20 +++++------
>   drivers/net/bnx2x/bnx2x.c                          | 40 +++++++++++-----------
>   drivers/net/bnx2x/bnx2x.h                          | 22 ++++++------
>   drivers/net/bnx2x/bnx2x_rxtx.c                     |  4 +--
>   drivers/net/bnx2x/bnx2x_stats.c                    |  2 +-
>   drivers/net/bnx2x/bnx2x_vfpf.c                     |  2 +-
>   drivers/net/bnx2x/ecore_sp.h                       |  2 +-
>   drivers/net/bnxt/bnxt.h                            | 10 +++---
>   drivers/net/bnxt/bnxt_cpr.h                        |  4 +--
>   drivers/net/bnxt/bnxt_ethdev.c                     |  2 +-
>   drivers/net/bnxt/bnxt_ring.c                       |  2 +-
>   drivers/net/bnxt/bnxt_ring.h                       |  2 +-
>   drivers/net/bnxt/bnxt_rxr.h                        |  4 +--
>   drivers/net/bnxt/bnxt_txr.h                        |  2 +-
>   drivers/net/bnxt/bnxt_vnic.c                       |  2 +-
>   drivers/net/bnxt/bnxt_vnic.h                       |  6 ++--
>   drivers/net/liquidio/lio_rxtx.c                    |  2 +-
>   drivers/net/liquidio/lio_rxtx.h                    |  4 +--
>   drivers/net/qede/base/bcm_osal.h                   |  2 +-
>   drivers/net/sfc/efsys.h                            |  2 +-
>   drivers/net/sfc/sfc_ef10_rx.c                      |  2 +-
>   drivers/net/sfc/sfc_ef10_tx.c                      |  4 +--
>   drivers/net/thunderx/base/nicvf_hw.c               |  2 +-
>   drivers/net/thunderx/base/nicvf_hw.h               |  2 +-
>   drivers/net/thunderx/base/nicvf_hw_defs.h          |  6 ++--
>   drivers/net/thunderx/nicvf_ethdev.c                |  4 +--
>   drivers/net/thunderx/nicvf_ethdev.h                |  4 +--
>   drivers/net/thunderx/nicvf_struct.h                |  6 ++--
>   drivers/net/virtio/virtio_rxtx.h                   |  4 +--
>   drivers/net/virtio/virtqueue.h                     |  2 +-
>   drivers/net/xenvirt/rte_eth_xenvirt.c              |  2 +-
>   drivers/net/xenvirt/rte_mempool_gntalloc.c         |  6 ++--
>   drivers/net/xenvirt/rte_xen_lib.c                  |  6 ++--
>   drivers/net/xenvirt/rte_xen_lib.h                  |  8 ++---
>   examples/l2fwd-crypto/main.c                       |  2 +-
>   lib/librte_cryptodev/rte_crypto.h                  |  2 +-
>   lib/librte_cryptodev/rte_crypto_sym.h              |  6 ++--
>   lib/librte_cryptodev/rte_cryptodev.h               |  2 +-
>   lib/librte_eal/bsdapp/eal/eal_memory.c             |  4 +--
>   lib/librte_eal/common/include/rte_malloc.h         |  2 +-
>   lib/librte_eal/common/include/rte_memory.h         | 18 +++++-----
>   lib/librte_eal/common/include/rte_memzone.h        |  2 +-
>   lib/librte_eal/common/rte_malloc.c                 |  2 +-
>   lib/librte_eal/linuxapp/eal/eal_memory.c           |  8 ++---
>   lib/librte_eal/linuxapp/eal/eal_xen_memory.c       |  4 +--
>   .../linuxapp/eal/include/exec-env/rte_kni_common.h | 19 +++++-----
>   lib/librte_mbuf/rte_mbuf.h                         |  8 ++---
>   lib/librte_mempool/rte_mempool.c                   | 18 +++++-----
>   lib/librte_mempool/rte_mempool.h                   | 14 ++++----
>   lib/librte_vhost/vhost.h                           |  2 +-
>   test/test/test_cryptodev.h                         |  2 +-
>   test/test/test_memzone.c                           |  8 ++---
>   68 files changed, 195 insertions(+), 194 deletions(-)
> 
> diff --git a/app/test-crypto-perf/cperf_test_vectors.h b/app/test-crypto-perf/cperf_test_vectors.h
> index 85955703c..a203272cf 100644
> --- a/app/test-crypto-perf/cperf_test_vectors.h
> +++ b/app/test-crypto-perf/cperf_test_vectors.h
> @@ -78,13 +78,13 @@ struct cperf_test_vector {
>   
>   	struct {
>   		uint8_t *data;
> -		phys_addr_t phys_addr;
> +		iova_addr_t phys_addr;
>   		uint16_t length;
>   	} aad;
>   
>   	struct {
>   		uint8_t *data;
> -		phys_addr_t phys_addr;
> +		iova_addr_t phys_addr;
>   		uint16_t length;
>   	} digest;
>   
> diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst
> index cddbd7bb8..719007b9f 100644
> --- a/doc/guides/contributing/documentation.rst
> +++ b/doc/guides/contributing/documentation.rst
> @@ -712,7 +712,7 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati
>        /**< Virtual address of the first mempool object. */
>        uintptr_t   elt_va_end;
>        /**< Virtual address of the <size + 1> mempool object. */
> -     phys_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT];
> +     iova_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT];
>        /**< Array of physical page addresses for the mempool buffer. */

Here and perhaps in other places - worth it to fix comments as well?

>   
>     This doesn't have an effect on the rendered documentation but it is confusing for the developer reading the code.
> @@ -731,7 +731,7 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati
>        /** Virtual address of the <size + 1> mempool object. */
>        uintptr_t   elt_va_end;
>        /** Array of physical page addresses for the mempool buffer. */
> -     phys_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT];
> +     iova_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT];
>   
>   * Check for Doxygen warnings in new code by checking the API documentation build::
>   

...

> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> @@ -58,7 +58,6 @@
>   
>   #ifndef _RTE_KNI_COMMON_H_
>   #define _RTE_KNI_COMMON_H_
> -
>   #ifdef __KERNEL__
>   #include <linux/if.h>
>   #define RTE_STD_C11
> @@ -66,6 +65,8 @@
>   #include <rte_common.h>
>   #endif
>   
> +typedef uint64_t iova_addr_t;
> +

Why was this added? (This also causes a compile issue according to build 
automation)

Thanks,
Anatoly

>   /**
>    * KNI name is part of memzone name.
>    */
> @@ -138,20 +139,20 @@ struct rte_kni_mbuf {
>   struct rte_kni_device_info {
>   	char name[RTE_KNI_NAMESIZE];  /**< Network device name for KNI */
>   
> -	phys_addr_t tx_phys;
> -	phys_addr_t rx_phys;
> -	phys_addr_t alloc_phys;
> -	phys_addr_t free_phys;
> +	iova_addr_t tx_phys;
> +	iova_addr_t rx_phys;
> +	iova_addr_t alloc_phys;
> +	iova_addr_t free_phys;

  reply	other threads:[~2017-09-18 14:06 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 15:15 [dpdk-dev] [PATCH v1 0/4] make dpdk iova aware Santosh Shukla
2017-08-14 15:15 ` [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t Santosh Shukla
2017-09-18 14:06   ` Burakov, Anatoly [this message]
2017-09-18 14:31     ` santosh
2017-09-18 14:32     ` Burakov, Anatoly
2017-08-14 15:15 ` [dpdk-dev] [PATCH v1 2/4] eal/memory: rename buf_physaddr to buf_iovaaddr Santosh Shukla
2017-08-14 15:15 ` [dpdk-dev] [PATCH v1 3/4] eal/memory: rename memory translational api to _iova types Santosh Shukla
2017-08-14 15:15 ` [dpdk-dev] [PATCH v1 4/4] doc: remove dpdk iova aware notice Santosh Shukla
2017-09-18 18:44   ` Mcnamara, John
2017-09-05 10:31 ` [dpdk-dev] [PATCH v2 0/5] make dpdk iova aware Santosh Shukla
2017-09-05 10:31   ` [dpdk-dev] [PATCH v2 1/5] eal: rename phys_addr_t to iova_addr_t Santosh Shukla
2017-09-18 15:19     ` Burakov, Anatoly
2017-09-05 10:31   ` [dpdk-dev] [PATCH v2 2/5] eal/memory: rename buf_physaddr to buf_iovaaddr Santosh Shukla
2017-09-18 15:20     ` Burakov, Anatoly
2017-09-05 10:31   ` [dpdk-dev] [PATCH v2 3/5] eal/memory: rename memseg member phys to iova addr Santosh Shukla
2017-09-18 15:04     ` Burakov, Anatoly
2017-09-18 15:08       ` santosh
2017-09-18 15:11         ` Burakov, Anatoly
2017-09-18 15:21     ` Burakov, Anatoly
2017-09-05 10:31   ` [dpdk-dev] [PATCH v2 4/5] eal/memory: rename memory api to iova types Santosh Shukla
2017-09-05 10:31   ` [dpdk-dev] [PATCH v2 5/5] doc: remove dpdk iova aware notice Santosh Shukla
2017-09-19 13:38     ` Mcnamara, John
2017-10-17 13:31   ` [dpdk-dev] [PATCH v2 0/5] make dpdk iova aware Thomas Monjalon
2017-10-17 14:12     ` santosh
2017-10-20 12:31   ` [dpdk-dev] [PATCH v3 0/6] " Santosh Shukla
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 1/6] eal: rename phys addr to iova addr Santosh Shukla
2017-10-23 20:32       ` Thomas Monjalon
2017-10-24  5:16         ` santosh
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 2/6] eal/memory: rename buf physaddr to buf iovaaddr Santosh Shukla
2017-10-23 20:15       ` Thomas Monjalon
2017-10-25  9:55         ` Olivier MATZ
2017-10-23 20:34       ` Thomas Monjalon
2017-10-24  5:17         ` santosh
2017-10-25  9:44       ` Olivier MATZ
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 3/6] eal/memory: rename memseg member phys to iova addr Santosh Shukla
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types Santosh Shukla
2017-11-03 11:11       ` Thomas Monjalon
2017-11-03 11:35         ` santosh
2017-11-03 13:58           ` Thomas Monjalon
2017-11-03 15:22             ` [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iovatypes Jonas Pfefferle1
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 5/6] doc: remove dpdk iova aware notice Santosh Shukla
2017-10-23 20:29       ` Thomas Monjalon
2017-10-24  5:06         ` santosh
2017-10-25  9:45           ` Thomas Monjalon
2017-10-25  9:50             ` Richardson, Bruce
2017-10-25 10:01               ` Thomas Monjalon
2017-10-25 10:05                 ` Bruce Richardson
2017-10-25 10:12                   ` Thomas Monjalon
2017-10-25 10:32                     ` Bruce Richardson
2017-10-20 12:31     ` [dpdk-dev] [PATCH v3 6/6] eal/common/rte_malloc: use pointer diff in virt2iova Santosh Shukla
2017-10-23 14:58     ` [dpdk-dev] [PATCH v3 0/6] make dpdk iova aware Thomas Monjalon
2017-10-24  5:12       ` santosh
2017-10-24  7:38         ` Thomas Monjalon
2017-11-06  1:41 ` [dpdk-dev] [PATCH v4 00/15] make DPDK IOVA aware Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 01/15] mem: hide physical address error in VA mode Thomas Monjalon
2017-11-06  5:39     ` santosh
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 02/15] mem: introduce IOVA type Thomas Monjalon
2017-11-06  5:38     ` santosh
2017-11-06  8:37       ` Thomas Monjalon
2017-11-06  8:51         ` santosh
2017-11-06  9:08           ` Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 03/15] mem: rename segment address from physical to IOVA Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 04/15] mem: rename address mapping function " Thomas Monjalon
2017-11-06  5:41     ` santosh
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 05/15] malloc: " Thomas Monjalon
2017-11-06  5:47     ` santosh
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 06/15] malloc: use pointer diff macro in IOVA mapping Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 07/15] memzone: rename address from physical to IOVA Thomas Monjalon
2017-11-06  5:50     ` santosh
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 08/15] mempool: rename addresses " Thomas Monjalon
2017-11-06  5:52     ` santosh
2017-11-06 15:44     ` Olivier MATZ
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 09/15] mempool: rename address mapping function " Thomas Monjalon
2017-11-06  5:54     ` santosh
2017-11-06 15:44     ` Olivier MATZ
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 10/15] mempool: rename populate functions " Thomas Monjalon
2017-11-06 15:49     ` Olivier MATZ
2017-11-06 15:58       ` Thomas Monjalon
2017-11-06 16:39         ` Olivier MATZ
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 11/15] mbuf: rename physical address " Thomas Monjalon
2017-11-06 15:52     ` Olivier MATZ
2017-11-06 16:00       ` Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 12/15] mbuf: rename data address helpers " Thomas Monjalon
2017-11-06 15:56     ` Olivier MATZ
2017-11-06 16:03       ` Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 13/15] cryptodev: rename physical address type " Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 14/15] drivers/net: " Thomas Monjalon
2017-11-06  1:41   ` [dpdk-dev] [PATCH v4 15/15] doc: add IOVA aware API changes in release notes Thomas Monjalon
2017-11-06  5:56     ` santosh
2017-11-06  8:50     ` Mcnamara, John
2017-11-06 22:48   ` [dpdk-dev] [PATCH v4 00/15] make DPDK IOVA aware Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a655cea-340a-1b7a-d0ba-01db39dbcd24@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).