* [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
@ 2021-09-08 1:39 Nicolas Chautru
2021-09-11 19:18 ` Tom Rix
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Chautru @ 2021-09-08 1:39 UTC (permalink / raw)
To: dev, gakhil, trix
Cc: thomas, mingshan.zhang, arun.joshi, stable, Nicolas Chautru
This patch fixes the issue by adjusting the outbound size after
turbodecoding when the appended CRC is meant to be dropped.
Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing")
Cc: stable@dpdk.org
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index 68ba523..b0485e7 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -1744,7 +1744,8 @@
next_triplet = acc100_dma_fill_blk_type_out(
desc, h_output, *h_out_offset,
- k >> 3, next_triplet, ACC100_DMA_BLKID_OUT_HARD);
+ (k - crc24_overlap) >> 3, next_triplet,
+ ACC100_DMA_BLKID_OUT_HARD);
if (unlikely(next_triplet < 0)) {
rte_bbdev_log(ERR,
"Mismatch between data to process and mbuf data length in bbdev_op: %p",
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
2021-09-08 1:39 [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped Nicolas Chautru
@ 2021-09-11 19:18 ` Tom Rix
2021-10-04 23:39 ` Chautru, Nicolas
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2021-09-11 19:18 UTC (permalink / raw)
To: Nicolas Chautru, dev, gakhil; +Cc: thomas, mingshan.zhang, arun.joshi, stable
On 9/7/21 6:39 PM, Nicolas Chautru wrote:
> This patch fixes the issue by adjusting the outbound size after
> turbodecoding when the appended CRC is meant to be dropped.
>
> Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 68ba523..b0485e7 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1744,7 +1744,8 @@
>
> next_triplet = acc100_dma_fill_blk_type_out(
> desc, h_output, *h_out_offset,
> - k >> 3, next_triplet, ACC100_DMA_BLKID_OUT_HARD);
> + (k - crc24_overlap) >> 3, next_triplet,
> + ACC100_DMA_BLKID_OUT_HARD);
> if (unlikely(next_triplet < 0)) {
> rte_bbdev_log(ERR,
> "Mismatch between data to process and mbuf data length in bbdev_op: %p",
Thanks for this change, looks good.
Reviewed-by: Tom Rix <trix@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
2021-09-11 19:18 ` Tom Rix
@ 2021-10-04 23:39 ` Chautru, Nicolas
2021-10-05 10:10 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Chautru, Nicolas @ 2021-10-04 23:39 UTC (permalink / raw)
To: Tom Rix, dev, gakhil; +Cc: thomas, Zhang, Mingshan, Joshi, Arun, stable
Hi Akhil,
Can this be applied?
Thanks
Nic
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Saturday, September 11, 2021 12:19 PM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> gakhil@marvell.com
> Cc: thomas@monjalon.net; Zhang, Mingshan <mingshan.zhang@intel.com>;
> Joshi, Arun <arun.joshi@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC
> is dropped
>
>
> On 9/7/21 6:39 PM, Nicolas Chautru wrote:
> > This patch fixes the issue by adjusting the outbound size after
> > turbodecoding when the appended CRC is meant to be dropped.
> >
> > Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c
> > b/drivers/baseband/acc100/rte_acc100_pmd.c
> > index 68ba523..b0485e7 100644
> > --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> > @@ -1744,7 +1744,8 @@
> >
> > next_triplet = acc100_dma_fill_blk_type_out(
> > desc, h_output, *h_out_offset,
> > - k >> 3, next_triplet,
> ACC100_DMA_BLKID_OUT_HARD);
> > + (k - crc24_overlap) >> 3, next_triplet,
> > + ACC100_DMA_BLKID_OUT_HARD);
> > if (unlikely(next_triplet < 0)) {
> > rte_bbdev_log(ERR,
> > "Mismatch between data to process and
> mbuf data length in
> > bbdev_op: %p",
>
> Thanks for this change, looks good.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
2021-10-04 23:39 ` Chautru, Nicolas
@ 2021-10-05 10:10 ` Akhil Goyal
2021-10-05 15:12 ` Chautru, Nicolas
0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2021-10-05 10:10 UTC (permalink / raw)
To: Chautru, Nicolas, Tom Rix, dev
Cc: thomas, Zhang, Mingshan, Joshi, Arun, stable
> Hi Akhil,
> Can this be applied?
The patch did not apply cleanly.
It is rebased and Applied to dpdk-next-crypto. Please check.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
2021-10-05 10:10 ` Akhil Goyal
@ 2021-10-05 15:12 ` Chautru, Nicolas
0 siblings, 0 replies; 5+ messages in thread
From: Chautru, Nicolas @ 2021-10-05 15:12 UTC (permalink / raw)
To: Akhil Goyal, Tom Rix, dev; +Cc: thomas, Zhang, Mingshan, Joshi, Arun, stable
Thanks Akhil. The applied rebase is fine.
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, October 5, 2021 3:10 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; Tom Rix
> <trix@redhat.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; Zhang, Mingshan <mingshan.zhang@intel.com>;
> Joshi, Arun <arun.joshi@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC
> is dropped
>
> > Hi Akhil,
> > Can this be applied?
> The patch did not apply cleanly.
> It is rebased and Applied to dpdk-next-crypto. Please check.
>
> Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-05 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 1:39 [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped Nicolas Chautru
2021-09-11 19:18 ` Tom Rix
2021-10-04 23:39 ` Chautru, Nicolas
2021-10-05 10:10 ` Akhil Goyal
2021-10-05 15:12 ` Chautru, Nicolas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).