From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>
Subject: RE: [PATCH v2 3/6] graph: replace unnecessary comma operator
Date: Fri, 15 Aug 2025 13:49:20 +0000 [thread overview]
Message-ID: <2a6815ac2e1f4fafbe71ee869513d02c@huawei.com> (raw)
In-Reply-To: <20250814212901.88863-4-stephen@networkplumber.org>
> Use of comma as statement separator is discouraged and
> reported as warning by clang with -Wcomma
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/graph/graph_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
> index eac73cbf71..588508b473 100644
> --- a/lib/graph/graph_stats.c
> +++ b/lib/graph/graph_stats.c
> @@ -254,7 +254,7 @@ stats_mem_populate(struct rte_graph_cluster_stats **stats_in,
> *stats_in = NULL;
>
> /* Clear the new struct cluster_node area */
> - cluster = RTE_PTR_ADD(stats, stats->sz),
> + cluster = RTE_PTR_ADD(stats, stats->sz);
> memset(cluster, 0, stats->cluster_node_size);
> memcpy(cluster->stat.name, graph_node->node->name, RTE_NODE_NAMESIZE);
> cluster->stat.id = graph_node->node->id;
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 2.47.2
>
next prev parent reply other threads:[~2025-08-15 13:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-15 13:48 ` Konstantin Ananyev
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-15 13:47 ` Konstantin Ananyev
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-15 13:49 ` Konstantin Ananyev [this message]
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 13:50 ` Konstantin Ananyev
2025-08-14 21:28 ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 14:00 ` Konstantin Ananyev
2025-08-15 0:30 ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
2025-08-15 6:40 ` Morten Brørup
2025-08-15 16:15 ` Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 0/7] avoid unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 1/7] eal: replace unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 2/7] ipsec: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 3/7] graph: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 4/7] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 5/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 6/7] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 7/7] config: enable comma warnings Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a6815ac2e1f4fafbe71ee869513d02c@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stephen@networkplumber.org \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).