From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DF5B46D2B; Fri, 15 Aug 2025 15:49:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28C28402D9; Fri, 15 Aug 2025 15:49:22 +0200 (CEST) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 937604026C for ; Fri, 15 Aug 2025 15:49:21 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4c3NgY6lXYz6L4xG; Fri, 15 Aug 2025 21:46:33 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 44653140279; Fri, 15 Aug 2025 21:49:21 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Aug 2025 15:49:21 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Fri, 15 Aug 2025 15:49:20 +0200 From: Konstantin Ananyev To: Stephen Hemminger , "dev@dpdk.org" CC: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan Subject: RE: [PATCH v2 3/6] graph: replace unnecessary comma operator Thread-Topic: [PATCH v2 3/6] graph: replace unnecessary comma operator Thread-Index: AQHcDWKb8CBJqVhskkm7BAb//LShzrRju+Dw Date: Fri, 15 Aug 2025 13:49:20 +0000 Message-ID: <2a6815ac2e1f4fafbe71ee869513d02c@huawei.com> References: <20250312232739.228295-1-stephen@networkplumber.org> <20250814212901.88863-1-stephen@networkplumber.org> <20250814212901.88863-4-stephen@networkplumber.org> In-Reply-To: <20250814212901.88863-4-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.146.251] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Use of comma as statement separator is discouraged and > reported as warning by clang with -Wcomma >=20 > Signed-off-by: Stephen Hemminger > --- > lib/graph/graph_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c > index eac73cbf71..588508b473 100644 > --- a/lib/graph/graph_stats.c > +++ b/lib/graph/graph_stats.c > @@ -254,7 +254,7 @@ stats_mem_populate(struct rte_graph_cluster_stats **s= tats_in, > *stats_in =3D NULL; >=20 > /* Clear the new struct cluster_node area */ > - cluster =3D RTE_PTR_ADD(stats, stats->sz), > + cluster =3D RTE_PTR_ADD(stats, stats->sz); > memset(cluster, 0, stats->cluster_node_size); > memcpy(cluster->stat.name, graph_node->node->name, RTE_NODE_NAMESIZE); > cluster->stat.id =3D graph_node->node->id; > -- Acked-by: Konstantin Ananyev =20 > 2.47.2 >=20