From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A25D9A0C4D; Fri, 13 Aug 2021 14:46:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B7504069C; Fri, 13 Aug 2021 14:46:57 +0200 (CEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id 6E4E040140 for ; Fri, 13 Aug 2021 14:46:56 +0200 (CEST) Received: by mail-wr1-f45.google.com with SMTP id x10so6834885wrt.8 for ; Fri, 13 Aug 2021 05:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=eoVhf9YqTEI+fzbYWi9sztbfKNMkdCtQjfIFm/D5p/Y=; b=OtPBowIaJlubyEyIeL5zejZ18fYuaJ8uINDTde5eS2BrVMaGGmY9YS3Tenuk2r7eW9 Bf7eSklI0wz1lax2O/rW0Tlx+lwFqQAe7EA3qh6NCoU6J/Kxp79L1j389bZtR3KHjkQ2 yufykoygGQw5UOi4ipX1+SdCE54HbdP2rmOO9w3TZcZNnmSIMKMhtKzbJ07o42pEFPOH N6f//KLS8X6K9c05unWCGWZtaUwsj6bXNfQya0/Ld5exHwx/EOfbVHkVPnN6RLT7imN2 h4iQ12ID8iAGszBDsKmYlGUgWydaLhzItbxmFLO/4PDcG5ODupztwZMCBQMn1gMSN8AW KDww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=eoVhf9YqTEI+fzbYWi9sztbfKNMkdCtQjfIFm/D5p/Y=; b=eUggGysysmZUyr9DfVtfJEOA7QWng0cLYsdwuYFjZHSvzch7oxvJj1kVjPPEHG32+3 9l4kyY03vjlLSbO4AiQ6gDHaWKCsEn7lfRdW1+nm0USyroP7JiZsLniS3LBBqu2H/EOy Zrkq3XvoUXAeq6o88t6voiSC8B25ec74NBP5AgzUILE9YT0s4rCV/m/03CgGkCfRLTAr +rfuWkNocrUbg8ZSTcgjFOE1ICdlwD2+3NyDZ1NR3mIqPrGwfO60S5LuLfg8/F+9lPaX 8Z7U442pHEpHjAygYUgLf8PkC8AYjyktF9sf1Dtm7HTmayMxJhfscINSOnk98Aj2zCo4 zYng== X-Gm-Message-State: AOAM532JL+4+mS2Sd+xx9upMA+e/whi/slqVkN3NvKxV2Q8iOnhtUQi2 KtNSP2w4zeMchdNYok/P8iGcLoBC5RHLmainl2NaNNFLJIthe0b4vqsKHnR0C0d9qDCHycJYvtu FhNjAdX3N6yupV9fcwOYVehK8Pc+idTjEl21WTYAI2ZCVaTY0Wqw9dwY5mv+5//eE X-Google-Smtp-Source: ABdhPJz5ARBcRpWefcArmUyLvw6IU3gBtlrZs3fwNX1Rlg/OekrcoZ6TxBaF3kdmaUE3YVU1iMs2MA== X-Received: by 2002:a5d:500a:: with SMTP id e10mr818459wrt.332.1628858816000; Fri, 13 Aug 2021 05:46:56 -0700 (PDT) Received: from [10.1.2.56] ([105.30.25.75]) by smtp.gmail.com with UTF8SMTPSA id k17sm1516341wrn.8.2021.08.13.05.46.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 05:46:55 -0700 (PDT) Message-ID: <2a68e3ff-93af-bc89-9f1c-dbd59d97d26a@netronome.com> Date: Fri, 13 Aug 2021 14:46:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: dev@dpdk.org References: <20210716083545.34444-1-heinrich.kuhn@netronome.com> <20210729134711.35870-1-heinrich.kuhn@netronome.com> From: Heinrich Kuhn In-Reply-To: <20210729134711.35870-1-heinrich.kuhn@netronome.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/07/29 15:47, Heinrich Kuhn wrote: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reorganized into the familiar > structure seen in other PMD's. Apart form adopting the common PMD layout > this change should also aid in future feature development to the NFP > PMD. The previous layout where most of the logic resided in a single > file (nfp_net.c) would have become tedious to support going forward. > > v3: > * Avoid squashing the new firmware loader helper added in: > https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 > * Add dependency to patch-93299 > > v2: > * Added missing sign-off's > > --- I think this refactor is a step in the right direction for the NFP PMD. I do have a question/concern regarding future bug fixes. If this is merged, back-porting any bug fixes will require a little bit more effort since the code base will differ quite substantially for some time. If there is a strong preference to avoid a situation like this we can certainly live without this refactor Regards, Heinrich