From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 092A520F for ; Thu, 18 May 2017 12:59:25 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2017 03:59:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,358,1491289200"; d="scan'208";a="88972399" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 18 May 2017 03:59:12 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1495023908-10977-1-git-send-email-arybchenko@solarflare.com> <1495023908-10977-2-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <2a7d4dc5-2306-b799-5fc1-c927dd07db53@intel.com> Date: Thu, 18 May 2017 11:59:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495023908-10977-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] net/sfc: use locally stored data for logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 10:59:26 -0000 On 5/17/2017 1:25 PM, Andrew Rybchenko wrote: > Required to be able to use logging in the secondary process > where Ethernet device pointer stored in sfc_adapter is invalid. > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > diff --git a/drivers/net/sfc/sfc_log.h b/drivers/net/sfc/sfc_log.h > index d0f8921..6c43925 100644 > --- a/drivers/net/sfc/sfc_log.h > +++ b/drivers/net/sfc/sfc_log.h > @@ -35,18 +35,16 @@ > /* Log PMD message, automatically add prefix and \n */ > #define SFC_LOG(sa, level, ...) \ > do { \ > - const struct rte_eth_dev *_dev = (sa)->eth_dev; \ > - const struct rte_pci_device *_pci_dev = \ > - RTE_ETH_DEV_TO_PCI(_dev); \ > + const struct sfc_adapter *_sa = (sa); \ Getting following build error with clang and icc [1]. I guess that is because "_sa" declared on both sfc_log_init() and in the macro that function uses (SFC_LOG). [1] .../drivers/net/sfc/sfc_filter.c:121:2: error: variable '_sa' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] sfc_log_init(sa, "failed %d", rc); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/sfc/sfc_log.h:68:12: note: expanded from macro 'sfc_log_init' SFC_LOG(_sa, INFO, \ ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/sfc/sfc_log.h:38:36: note: expanded from macro 'SFC_LOG' const struct sfc_adapter *_sa = (sa); \ ~~~ ^~