Re: [PATCH v2 08/45] common/sfc_efx/base: add Medford4 support to PHY module

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 4/23/25 18:59, Ivan Malov wrote:
> From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
> 
> Use common EF10 method table for that.
> 
> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
> Reviewed-by: Andy Moreton <andy.moreton@amd.com>
> ---
>   drivers/common/sfc_efx/base/efx_phy.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/common/sfc_efx/base/efx_phy.c b/drivers/common/sfc_efx/base/efx_phy.c
> index d55becae18..3d792f20b8 100644
> --- a/drivers/common/sfc_efx/base/efx_phy.c
> +++ b/drivers/common/sfc_efx/base/efx_phy.c
> @@ -114,6 +114,12 @@ efx_phy_probe(
>   		break;
>   #endif	/* EFSYS_OPT_MEDFORD2 */
>   
> +#if EFSYS_OPT_MEDFORD4
> +	case EFX_FAMILY_MEDFORD4:
> +		epop = &__efx_phy_ef10_ops;
> +	break;

Strange location of break

> +#endif	/* EFSYS_OPT_MEDFORD4 */
> +
>   	default:
>   		rc = ENOTSUP;
>   		goto fail1;