From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E4A75A56E for ; Sat, 20 Jan 2018 15:31:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2018 06:31:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,386,1511856000"; d="scan'208";a="21274768" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.25]) ([10.252.20.25]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jan 2018 06:31:03 -0800 From: Ferruh Yigit To: Xiao Wang , yliu@fridaylinux.org, olivier.matz@6wind.com, maxime.coquelin@redhat.com, Thomas Monjalon Cc: dev@dpdk.org, tiwei.bie@intel.com, stephen@networkplumber.org References: <20180110012356.57456-4-xiao.w.wang@intel.com> <20180116214103.67803-1-xiao.w.wang@intel.com> <20180116214103.67803-6-xiao.w.wang@intel.com> Message-ID: <2ac603a0-f4a1-ce56-a8a1-f42ea7a2225b@intel.com> Date: Sat, 20 Jan 2018 14:31:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 5/5] net/virtio: support GUEST ANNOUNCE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2018 14:31:06 -0000 On 1/19/2018 5:33 PM, Ferruh Yigit wrote: > On 1/16/2018 9:41 PM, Xiao Wang wrote: >> When live migration is done, for the backup VM, either the virtio >> frontend or the vhost backend needs to send out gratuitous RARP packet >> to announce its new network location. >> >> This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live >> migration scenario where the vhost backend doesn't have the ability to >> generate RARP packet. >> >> Brief introduction of the work flow: >> 1. QEMU finishes live migration, pokes the backup VM with an interrupt. >> 2. Virtio interrupt handler reads out the interrupt status value, and >> realizes it needs to send out RARP packet to announce its location. >> 3. Pause device to stop worker thread touching the queues. >> 4. Inject a RARP packet into a Tx Queue. >> 5. Ack the interrupt via control queue. >> 6. Resume device to continue packet processing. >> >> Signed-off-by: Xiao Wang >> Reviewed-by: Maxime Coquelin > > > Hi Yuanhan, > > This commit breaks the build! I switched two patches and problem gone, like: first: net: fixup RARP generation second: net/virtio: support GUEST ANNOUNCE >>From my point of view nothing more needs to be done, but can you please double check the patches. Thanks, ferruh > > As far as I understand you send a fix but merged into other patch, which leaves > this commit still broken. > > What do you think sending a fix that can be mergable to this one, so I can > squash it on next-net? > > Thanks, > ferruh >