From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C5EFA04B5; Mon, 2 Dec 2019 17:06:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B0F51B9B7; Mon, 2 Dec 2019 17:06:57 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A40D72BD8 for ; Mon, 2 Dec 2019 17:06:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 08:06:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204608892" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga008.jf.intel.com with ESMTP; 02 Dec 2019 08:06:53 -0800 To: Alfredo Cardigliano , Thomas Monjalon , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <20191015082235.28639-1-cardigliano@ntop.org> <20191015082235.28639-2-cardigliano@ntop.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <2acb0ec0-2fa5-daec-121d-35b8cdadb70f@intel.com> Date: Mon, 2 Dec 2019 16:06:52 +0000 MIME-Version: 1.0 In-Reply-To: <20191015082235.28639-2-cardigliano@ntop.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 01/17] net/ionic: add skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add makefile and config file options to compile the Pensando ionic PMD. > Add feature and version map file. > Update maintainers file. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > MAINTAINERS | 6 +++ > config/common_base | 5 ++ > doc/guides/nics/features/ionic.ini | 8 +++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/ionic.rst | 35 +++++++++++++ > drivers/net/Makefile | 1 + > drivers/net/ionic/Makefile | 58 +++++++++++++++++++++ > drivers/net/ionic/meson.build | 8 +++ > drivers/net/ionic/rte_pmd_ionic_version.map | 5 ++ > mk/rte.app.mk | 1 + > 10 files changed, 128 insertions(+) > create mode 100644 doc/guides/nics/features/ionic.ini > create mode 100644 doc/guides/nics/ionic.rst > create mode 100644 drivers/net/ionic/Makefile > create mode 100644 drivers/net/ionic/meson.build > create mode 100644 drivers/net/ionic/rte_pmd_ionic_version.map Can you please add the new PMD support to the release notes (release notes of 20.02)? <...> > @@ -0,0 +1,35 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. Why it is GPL-2.0 licensed? What is the license of the PMD overall? > + > +IONIC Driver > +============ > + > +The ionic driver provides support for Pensando server adapters. Can you please provide a link to the product page to get more detailed information? <...> > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_pmd_ionic.a > + > +CFLAGS += -DALLOW_EXPERIMENTAL_API Is the allow exprerimental flag really required? If so can you please add the experimental APIs used as a comment. > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + > +EXPORT_MAP := rte_pmd_ionic_version.map > + > +LIBABIVER := 2 We are not using individual library versioning anymore, please drop this. > + > +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) > +# > +# CFLAGS for icc > +# > +CFLAGS += -diag-disable 174 -diag-disable 593 -diag-disable 869 > +CFLAGS += -diag-disable 981 -diag-disable 2259 -diag-disable 3656 This makefile looks like copy/paste from somewhere, please don't add these flags unless they really are needed. > + > +else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > +# > +# CFLAGS for clang > +# > +CFLAGS += -Wno-unused-parameter -Wno-unused-value -Wno-strict-aliasing > +CFLAGS += -Wno-format-extra-args > + > +else > +# > +# CFLAGS for gcc > +# > +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > +CFLAGS += -Wno-deprecated -Wno-unused-parameter -Wno-unused-value > +CFLAGS += -Wno-strict-aliasing -Wno-format-extra-args > +CFLAGS += -Wno-missing-field-initializers -Wno-pointer-arith > +endif > + > +ifeq ($(shell test $(GCC_VERSION) -ge 70 && echo 1), 1) > +CFLAGS += -Wno-implicit-fallthrough > +endif > + > +endif > + > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash > +LDLIBS += -lrte_bus_pci Same here, please don't include anly library that is not really needed. > + > +# > +# all source are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_IONIC_PMD) += > + > +include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/net/ionic/meson.build b/drivers/net/ionic/meson.build > new file mode 100644 > index 000000000..502076e3c > --- /dev/null > +++ b/drivers/net/ionic/meson.build > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Pensando > + > +version = 1 Same here, can drop the version. > + > +sources = files( > +) > + > diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map > new file mode 100644 > index 000000000..96f83bd6c > --- /dev/null > +++ b/drivers/net/ionic/rte_pmd_ionic_version.map > @@ -0,0 +1,5 @@ > +DPDK_2.0 { The prefix is the now ABI version, you can use 'DPDK_20.0' for it.