From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A1B6BA0C43;
	Tue, 19 Oct 2021 11:11:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 89CD740142;
	Tue, 19 Oct 2021 11:11:00 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 097BD4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 11:10:59 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8A0F87F56B;
 Tue, 19 Oct 2021 12:10:58 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8A0F87F56B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634634658;
 bh=B1s7bBcWqX8XsAcyl2tdprMB9nahvoUmRXSCiaJFJQQ=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=U7srkJ/u5LL9MU0IW/DeU+RfKHB0RdpEylUhyA+Tky1n7+LxB+axl29hwvywSYl36
 h6tQeC7cQvajupNB+jX3VdfTyAIWIm81mgaiQrQSktCWPnvWFhPeend72cb9YBdkud
 mlQvjq6qA1Liq1mTmsGMMAX4Wp6PR9/XSp/lebRk=
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, Jerin Jacob <jerinj@marvell.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori
 <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,
 Harman Kalra <hkalra@marvell.com>, Anoob Joseph <anoobj@marvell.com>,
 dev <dev@dpdk.org>
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211018144907.1145028-4-andrew.rybchenko@oktetlabs.ru>
 <CAJFAV8x3KOi_8kXqtm9MY0oEEH2awbp4MGpioV_5cijqve66+A@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <2af0d41e-015e-1ba2-98d3-52651cb3add7@oktetlabs.ru>
Date: Tue, 19 Oct 2021 12:10:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8x3KOi_8kXqtm9MY0oEEH2awbp4MGpioV_5cijqve66+A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 3/6] mempool: add namespace to internal but
 still visible API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 11:47 AM, David Marchand wrote:
> On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Add RTE_ prefix to internal API defined in public header.
>> Use the prefix instead of double underscore.
>> Use uppercase for macros in the case of name conflict.
> 
> Fwiw, I see no use out of dpdk for those helpers/macros.
> 
> $ git grep-all -E
> '\<(__MEMPOOL_STAT_ADD|__mempool_contig_blocks_check_cookies|__mempool_check_cookies|__mempool_generic_get|__mempool_generic_put|__mempool_get_trailer|__mempool_get_header)\>'
> 
> Not a review, just something that caught my eye below:
> 
> [snip]
> 
>> @@ -1384,7 +1385,7 @@ rte_mempool_put_bulk(struct rte_mempool *mp, void * const *obj_table,
>>         struct rte_mempool_cache *cache;
>>         cache = rte_mempool_default_cache(mp, rte_lcore_id());
>>         rte_mempool_trace_put_bulk(mp, obj_table, n, cache);
>> -       rte_mempool_generic_put(mp, obj_table, n, cache);
>> +       rte_mempool_do_generic_put(mp, obj_table, n, cache);
> 
> Is this change expected?

My bad. Many thanks for very careful review. Will fix in v2.

> 
> 
>>  }
>>
>>  /**
> 
> [snip]
> 
> 
>> @@ -1541,7 +1542,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned int n)
>>         struct rte_mempool_cache *cache;
>>         cache = rte_mempool_default_cache(mp, rte_lcore_id());
>>         rte_mempool_trace_get_bulk(mp, obj_table, n, cache);
>> -       return rte_mempool_generic_get(mp, obj_table, n, cache);
>> +       return rte_mempool_do_generic_get(mp, obj_table, n, cache);
>>  }
>>
>>  /**
> 
> Idem.

Same here.