DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
	"Maciej Czekaj [C]" <mczekaj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
Date: Mon, 4 Oct 2021 12:30:05 +0100	[thread overview]
Message-ID: <2af777bc-8092-ed51-c427-85c4d8b3e52e@intel.com> (raw)
In-Reply-To: <PH0PR18MB40862D189B08C685712F55D5DEAE9@PH0PR18MB4086.namprd18.prod.outlook.com>

On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for 64-bit Linux.
>>>
>>
>> Hi Pavan,
>>
>> Isn't it possible to provide a commit log in the kernel side etc, that let
>> others to verify why only 64 bit is required, or if someone want to
>> support
>> 32bit that may help them to investigate the source of the restriction.
> 
> Arch 32 support is not implemented on ThunderX, so 32bit will not run.
> 

I see, is following correct:
All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF is
supported by Linux kernel driver. And Linux kernel driver doesn't support arch32.

Is something changed in kernel driver side to drop the 32bit support?
If it was not supported at all, what is the motivation to disable the DPDK
drivers now?

>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>> ---
>>>  v5 Changes
>>>  - s/fuction/function.
>>>
>>>  v4 Changes:
>>>  - Update commit message regarding dependency on AF driver.
>>>
>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>  # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>      build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>      subdir_done()
>>>  endif
>>>
>>> --
>>> 2.17.1
>>>
> 


  reply	other threads:[~2021-10-04 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 10:02 Pavan Nikhilesh Bhagavatula
2021-10-04 11:30 ` Ferruh Yigit [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-10-04 12:01 Pavan Nikhilesh Bhagavatula
2021-10-04 12:49 ` Ferruh Yigit
2021-10-04 11:34 Pavan Nikhilesh Bhagavatula
2021-10-04 11:50 ` Ferruh Yigit
2021-10-03 20:36 [dpdk-dev] [PATCH v4 " pbhagavatula
2021-10-04  5:56 ` [dpdk-dev] [PATCH v5 " pbhagavatula
2021-10-04  9:05   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2af777bc-8092-ed51-c427-85c4d8b3e52e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mczekaj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).