From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1079CA09E4; Sat, 5 Dec 2020 01:56:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 350F62C6E; Sat, 5 Dec 2020 01:56:27 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7A2E62C58 for ; Sat, 5 Dec 2020 01:56:25 +0100 (CET) IronPort-SDR: wyD+ImqqZDDKs5eGeQjEv9yht7xyjCeyxxitTRwxT4/rEEIs9ezOeL6DgPHWvYGJugJ8/Luzrc QzWHTTHefTaA== X-IronPort-AV: E=McAfee;i="6000,8403,9825"; a="161240593" X-IronPort-AV: E=Sophos;i="5.78,394,1599548400"; d="scan'208";a="161240593" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 16:56:23 -0800 IronPort-SDR: hxnS4YKB4txPFbHOrUSCgtITtux5mi1HGEmcwQwX3MAkzQPkCCreJxoElXVI3TEoGjeMJbfAdY dunnLNE0mevw== X-IronPort-AV: E=Sophos;i="5.78,394,1599548400"; d="scan'208";a="551159142" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.209.62.157]) ([10.209.62.157]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 16:56:22 -0800 To: Tal Shnaiderman , dev@dpdk.org Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com References: <20201126080639.16240-1-talshn@nvidia.com> From: "Kadam, Pallavi" Message-ID: <2b0afab6-ad6e-10cf-6055-a07a77d075c4@intel.com> Date: Fri, 4 Dec 2020 16:56:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201126080639.16240-1-talshn@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tal, On 11/26/2020 12:06 AM, Tal Shnaiderman wrote: > interrupt callback register is not implemented in Windows. > Add stub with -ENOTSUP return value and export the function. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 6a6be1cfa6..08cf25ea01 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -63,6 +63,7 @@ EXPORTS > rte_get_tsc_hz > rte_hexdump > rte_hypervisor_get > + rte_intr_callback_register > rte_intr_rx_ctl > rte_lcore_count > rte_lcore_has_role > diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c > index 6c64a48f34..fea338d705 100644 > --- a/lib/librte_eal/windows/eal_interrupts.c > +++ b/lib/librte_eal/windows/eal_interrupts.c > @@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg) > > return 0; > } > + > +int > +rte_intr_callback_register( > + __rte_unused const struct rte_intr_handle *intr_handle, > + __rte_unused rte_intr_callback_fn cb, > + __rte_unused void *cb_arg) > +{ > + return -ENOTSUP; > +} We have also included the same code as it is required to compile i40e PMD. Will remove it from our patch once this code is merged. Thanks,