From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>, taox.zhu@intel.com
Cc: konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events
Date: Mon, 17 Feb 2020 13:01:12 +0000 [thread overview]
Message-ID: <2b14bca2-f69c-bd29-8e6c-65a174ed609e@intel.com> (raw)
In-Reply-To: <20200215154150.GI16933@intel.com>
On 2/15/2020 3:41 PM, Ye Xiaolong wrote:
> On 01/15, taox.zhu@intel.com wrote:
>> From: Zhu Tao <taox.zhu@intel.com>
>>
>> IXGBE link status task use rte alarm thread in old implementation.
>
> s/use/uses
>
>> Sometime ixgbe link status task takes up to 9 seconds. This will
>> severely affect the rte-alarm-thread-dependent a task in the
>> system, like interrupt or hotplug event. So replace with a
>
> s/a/an
>
>> independent thread which has the same thread affinity settings
>> as rte interrupt.
>>
>> Fixes: 0408f47b ("net/ixgbe: fix busy polling while fiber link update")
>
> Should be:
>
> Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
>
>> Cc: stable@dpdk.org
>>
>
> Applied to dpdk-next-net-intel with Konstantin's ack, Thanks.
>
Shared build is failing because of missing pthread library, fixing while merging
to next-net:
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index 8b9d51f75..aec56a680 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -57,6 +57,7 @@ endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
LDLIBS += -lrte_bus_pci
+LDLIBS += -lpthread
#
# Add extra flags for base driver files (also known as shared code)
next prev parent reply other threads:[~2020-02-17 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 2:45 [dpdk-dev] [PATCH] " taox.zhu
2019-12-30 13:58 ` Ananyev, Konstantin
2020-01-02 9:58 ` Zhu, TaoX
2020-01-07 17:34 ` Ananyev, Konstantin
2020-01-15 19:38 ` [dpdk-dev] [PATCH v2] " taox.zhu
2020-01-15 23:41 ` Ananyev, Konstantin
2020-01-22 9:18 ` Ye Xiaolong
2020-02-15 15:41 ` Ye Xiaolong
2020-02-17 13:01 ` Ferruh Yigit [this message]
2020-02-20 15:37 ` Thomas Monjalon
2020-02-21 8:19 ` Zhu, TaoX
2020-02-21 8:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b14bca2-f69c-bd29-8e6c-65a174ed609e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=taox.zhu@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).