From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 055121B103 for ; Wed, 3 Oct 2018 12:53:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 03:53:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="97032762" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113]) ([10.237.220.113]) by orsmga002.jf.intel.com with ESMTP; 03 Oct 2018 03:53:41 -0700 To: Eric Zhang , john.mcnamara@intel.com, hemant.agrawal@nxp.com, Thomas Monjalon Cc: allain.legacy@windriver.com, matt.peters@windriver.com, dev@dpdk.org References: <1538409290-24998-1-git-send-email-eric.zhang@windriver.com> <1fb2710d-c54b-b794-5d14-78751a7663fc@windriver.com> From: "Burakov, Anatoly" Message-ID: <2b2f9f46-c178-3faa-013d-489afc9208e5@intel.com> Date: Wed, 3 Oct 2018 11:53:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1fb2710d-c54b-b794-5d14-78751a7663fc@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: update the doc for adding EAL option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 10:53:44 -0000 On 02-Oct-18 9:05 PM, Eric Zhang wrote: > > > On 10/02/2018 05:59 AM, Burakov, Anatoly wrote: >> Hi Eric, >> >> Ferruh has already mention that this should be part of the patch >> adding the --iova-mode flag, not separate (or at the very least be in >> the same patchset!). > OK. I will generate version 3 which has one patchset includes code and > document patches. >> >> In addition, the commit headline is very vague. Suggested rewording: >> >> doc: document --iova-mode EAL flag > ok. > >    On 01-Oct-18 4:54 PM, eric zhang wrote: >>> This patch updates Programmer's Guide and EAL parameter guides >>> to show EAL option "--iova-mode" support. >>> >>> Signed-off-by: eric zhang >>> --- >>>   doc/guides/prog_guide/env_abstraction_layer.rst | 8 ++++++++ >>>   doc/guides/testpmd_app_ug/run_app.rst           | 4 ++++ >>>   2 files changed, 12 insertions(+) >>> >>> diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst >>> b/doc/guides/prog_guide/env_abstraction_layer.rst >>> index d362c92..a47fb38 100644 >>> --- a/doc/guides/prog_guide/env_abstraction_layer.rst >>> +++ b/doc/guides/prog_guide/env_abstraction_layer.rst >>> @@ -321,6 +321,14 @@ Misc Functions >>>     Locks and atomic operations are per-architecture (i686 and x86_64). >>>   +IOVA Mode Configuration >>> +~~~~~~~~~~~~~~~~~~~~~~~ >>> + >>> +Auto detection of the IOVA mode, based on probing the PCI bus and >>> IOMMU configuration, may not report >>> +the desired addressing mode when virtual devices that are not >>> directly attached to the PCI bus are present. >>> +To facilitate forcing the IOVA mode to a specific value the EAL >>> command line option ``--iova-mode=mode`` can >>> +be used to select either physical addressing('pa') or virtual >>> addressing('va'). >> >> Presumably this isn't only applicable to PCI bus, but can be any bus, >> correct? > It should be applicable to any bus since it would override the result > from whatever bus scheme. > Do you suggest to not mention "PCI bus" in the description? Yes, that is what i was implying. Sorry i didn't make it clear enough. >> >>> + >>>   Memory Segments and Memory Zones (memzone) >>>   ------------------------------------------ >>>   diff --git a/doc/guides/testpmd_app_ug/run_app.rst >>> b/doc/guides/testpmd_app_ug/run_app.rst >>> index f301c2b..be2911c 100644 >>> --- a/doc/guides/testpmd_app_ug/run_app.rst >>> +++ b/doc/guides/testpmd_app_ug/run_app.rst >>> @@ -133,6 +133,10 @@ See the DPDK Getting Started Guides for more >>> information on these options. >> >> I wanted to ask why are you adding this to testpmd user guide, as this >> is an EAL parameter, not a testpmd parameter, but as far as i can >> tell, there isn't a central location where we document all EAL flags. > That's the place that I can find where most eal command-line options are > addressed. Yes. For now it's OK to put it into testpmd documentation. We'll fix this problem later. >> >> +Thomas, John >> >> This looks like a gap in our documentation. There should be a place >> where we can describe all EAL parameters. Since they can be >> OS-specific, it probably should be somewhere under Linux/FreeBSD GSG. >> Thoughts? >> >>>         Use malloc instead of hugetlbfs. >>>   +*   ``--iova-mode=mode`` >> >> Current style is to list all valid values, like this: >> >> ``--iova-mode `` > Maybe like "--iova-mode=" to comply with code Code actually doesn't care if you put a "=" sign there :) It is better to follow style the rest of documentation has. >> >>> + >>> +    Force IOVA mode to a specific value. Valid values are 'pa' or 'va'. >>> + >>>     Testpmd Command-line Options >>>   ---------------------------- >>> >> >> > > -- Thanks, Anatoly