From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 463C82BE1 for ; Fri, 30 Jun 2017 15:47:55 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 06:47:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,286,1496127600"; d="scan'208";a="105657757" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.199]) ([163.33.228.199]) by orsmga002.jf.intel.com with ESMTP; 30 Jun 2017 06:47:53 -0700 To: RongQiang Xie , jingjing.wu@intel.com References: <201706300158.v5U1wmLt087572@mse01.zte.com.cn> Cc: dev@dpdk.org From: Declan Doherty Message-ID: <2b44c5ee-b1ae-7f47-0c07-a0375f27584a@intel.com> Date: Fri, 30 Jun 2017 14:47:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <201706300158.v5U1wmLt087572@mse01.zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd:add bond type description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 13:47:56 -0000 On 30/06/2017 2:52 AM, RongQiang Xie wrote: > In function cmd_show_bonding_config_parsed() use number > represent the bond type,in order more detailed,add bond > type description otherwise we may confused about the number > type. > And also,The primary port just use in mode active backup > and tlb,so,when the mode is the active backup or tlb we > show the primary port info. > > Signed-off-by: RongQiang Xie > --- > app/test-pmd/cmdline.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 4eac498..1ae5fc0 100755 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -4455,6 +4455,7 @@ static void cmd_show_bonding_config_parsed(void *parsed_result, > printf("\tActive Slaves: []\n"); > > } > + > if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP || > bonding_mode == BONDING_MODE_TLB) { > primary_id = rte_eth_bond_primary_get(port_id); > Hey, I think you are missing some of your intended changes in this patch? I'm only seeing a white space addition. Also the body of your email seems to be merged with the emails subject line. Thanks Declan