From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0071.outbound.protection.outlook.com [104.47.32.71]) by dpdk.org (Postfix) with ESMTP id E41A81BAE4 for ; Thu, 26 Oct 2017 15:16:47 +0200 (CEST) Received: from DM5PR03CA0048.namprd03.prod.outlook.com (2603:10b6:4:3b::37) by DM2PR0301MB0734.namprd03.prod.outlook.com (2a01:111:e400:3c0d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Thu, 26 Oct 2017 13:16:45 +0000 Received: from BN1BFFO11FD038.protection.gbl (2a01:111:f400:7c10::1:110) by DM5PR03CA0048.outlook.office365.com (2603:10b6:4:3b::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.178.6 via Frontend Transport; Thu, 26 Oct 2017 13:16:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD038.mail.protection.outlook.com (10.58.144.101) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.156.4 via Frontend Transport; Thu, 26 Oct 2017 13:16:45 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9QDGcaH007093; Thu, 26 Oct 2017 06:16:39 -0700 To: Thomas Monjalon CC: Radu Nicolau , David Marchand , , Declan Doherty , Pablo de Lara , Hemant Agrawal , , , , Jerin Jacob , "Mcnamara, John" , "Ananyev, Konstantin" , , Olivier Matz References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1837995.9rLZR0Gx80@xps> <8645d9c8-c2e6-b033-1438-97ef2021ccb2@nxp.com> <1548422.ftI5jb3vlP@xps> From: Akhil Goyal Message-ID: <2b57aec6-fc52-5d78-37cc-3eb3b19ac90c@nxp.com> Date: Thu, 26 Oct 2017 18:46:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1548422.ftI5jb3vlP@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131534974055762494; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(39380400002)(39860400002)(376002)(346002)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(199003)(36756003)(33646002)(5660300001)(69596002)(93886005)(65826007)(65956001)(2950100002)(229853002)(47776003)(65806001)(498600001)(97736004)(2906002)(64126003)(6916009)(104016004)(85426001)(305945005)(4326008)(31686004)(50466002)(356003)(53936002)(6246003)(7416002)(23676002)(561944003)(81156014)(316002)(58126008)(81166006)(83506002)(54906003)(53546010)(77096006)(8676002)(105606002)(230700001)(8936002)(54356999)(106466001)(68736007)(8656006)(86362001)(76176999)(189998001)(50986999)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0734; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD038; 1:2tZov4CuoxqecbujdQNDNjy+c8bAxfIGyThKnDXR7vs7lTeVoZd3zrDTlb/QA8jNRlv00mcJysAodhfMPCm4I5B24L4k+pbVN/E5/j5/OE4ULxOtjLZrXlJS6+8hQ5pr X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c2797c6-4721-45e6-4a3e-08d51c73ce99 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4628075)(201703131517081)(2017052603199); SRVR:DM2PR0301MB0734; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 3:WtHVjJfxdRhTMuJ6vIaC4xGiBz6WKg+n+LbLTzOs8O7NjGWFWKwVmqX7+RuYxqNYkBM9ZlO4HVSKNjFlUvPDqRJ9y6Iy34qAdjQCt3cHLcpWYuWjrCkaLhHAobY0S4VM9tWIT3RHY2AHanMxSLPow+axeuvmxKlWTmx9PI6Yk/JoKztwFt+tf2Lza0RUxNHYRE4CT49xibtYSi620wYMmKN38RyaIhxjxVkQW0OiuElbD5KmcBnzx010SyikiNzZOGHm+ZtZLJRcgqe9JILIcyZ8TBNy/PaFfId4uEz5NViMSfb6qi4whAx12nbwrnky/ZpvcsxErCgRVshKBOf88A==; 25:SRHIkrkFMqte9zXUZR3GGhZVDZTQxSuFdEAgaFNxT64XvOin1ielDXpYHuo6UImL06n0TITScDi5uNkBbgIqERTUJqqSqqwGiF85jPI2XaKN/xn1srgOpKMftUdHhz14O+bqqY6wPUA9+fviCEVgkIoJn8/UvFsMsAbe91se6Hp8e2vXoPmBdkiAn7PjqGLMpFLcC6s6vm6ki4Jeeo9jC1r9BgOrZFZD6kk7ihx2ao0IG1TT48kX+hzN3kBnlkj3VVzSz6BFtEw8mTEAtjfDZkQKqi7MzJ7F+de8sRt79TI9s6wtwZsaZpEY+BfZwXyVsBLWvq3qnxmolx+ern35alEdW896On72OzBYFCUOLpI= X-MS-TrafficTypeDiagnostic: DM2PR0301MB0734: X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 31:5pTbvidqFCLvQ4gjUlZY/LCfA+0Gn4zSI/IT7nkpiewTooCUkTNFxMqhXxmfh3qSJ63hObdUiYDsJWYqu7ECQOlOvkY1yzOZuNmBatRa9Lf7gmLVqqKaAl1Ji38sRR36p4hMRigo1EHjrn2+lXzpi3QCYU6Lp/hp66YWwdOwh3abFOCjzMUu5DU5TT+gsZtpXaiP2EFzgDEeSPiOF8w9a4M82CNsM54xI7F48sX5uys=; 4:+83vejqBspIfPjnMGj4ASyyeqG9W71pDjGTD8/FS1XFAhPNeF2PWeWnV9ICzDpn0CwH/X1oNUQBObnm/3+4oPHrHJZjz6vBftu/upzkhn3VQrKEcz1ha9VODX3lZemw2OdgA1jZ0ITRwRBr14PV9gxm/rL0GL14tgjlX1ipa2GRNCK7BvBzI/xhRJ59uzkVKfxQVIZ+ikR+epCE44vaHUKUABXdg+mECmlp/TIv4q8QACYZkYXOMdwKybr+lWdMkhlq8gXYWxP739tz/aCqNVA06XL87AAWu528ffka1sSx35ZmwH5RN8zVBAiyEAYcjGTbHC31a/D5NLB3zlKkxEQ== X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(3231020)(6055026)(6096035)(20161123561025)(20161123559100)(20161123565025)(20161123556025)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR0301MB0734; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR0301MB0734; X-Forefront-PRVS: 04724A515E X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA3MzQ7MjM6SC8yblNZV2k4V01NZzBDVXh6L3Nzb2RJ?= =?utf-8?B?c2V1MnFwTHY2NjJlTkpBdkVnSFRQQ24xN255SjF3d0FSNzVrcXY2ZFYvSUdp?= =?utf-8?B?MTFVN3MyV096Uk9mUGRtTzhHL3M3RzhPR3NTRXhJL1ZoR3pCTjZMb3BUcTlx?= =?utf-8?B?ZXZGTVd5MU9HaHo3L0NoZklUcjRVWjhuQUR0aHJaUDBNd0lzdmV4V2x6eXFG?= =?utf-8?B?anQvU1ErSTdpdWZ5eENKblNZMHE1eEEwa1Y4TkRYNm9iZkJIWTdXbnQ1cGFD?= =?utf-8?B?NW4zd0ltM0Yzd1YranlIYWpRT050OEtrQURkSXdlVU1kK2F6RTcrN1l4T2tQ?= =?utf-8?B?aE16V3dWNVRLbGxTcTA2V2JwT0JsWWxPQTZKV2hyUy9nU2VCelVRYlNBVGR2?= =?utf-8?B?a1NlSTRvSGVKd2JhNS9vcjBZY0c0VS9vRnNVU3pLM2pvelpndWs1Q3dyVEdM?= =?utf-8?B?dUF1OHMxK2ttNk1rOTY4ZTgxZ3Nwc0JIanVMZmpCWERkYjloVUhPa2ZSd3RP?= =?utf-8?B?TXR3YXAwQzFSWDNqT0dZNFAzNXVnTERscytIdlJUMlF3MXpNeTAwWk9uZlll?= =?utf-8?B?enRlaGloQkJJbnUvVmExSkM0aHpQWDV1bE84RDBMVWxMeUZZTkZWWVcyVmJo?= =?utf-8?B?YzRQZzZPR2JwT1hjbG5UaXU1WENJNmszeU9YZnczZzlwa2Ewc1c1RXZINlZY?= =?utf-8?B?VnBCNk13WlFidVZIYVIrR3RabVVBc2hrVmxxUjAvclBtdkFWTitpMmtld1lm?= =?utf-8?B?WVd2Z0NxbGsvQ002MU9RSGhrT0lMQnYrb0RubzUzcDA4NWFUMHdVNFZmbWxX?= =?utf-8?B?TXlZaWViUHd1T282ZXhnNTNJcWJtYzFFYUkzQ1ROMkdSNkVyNVJwT3h1eUlH?= =?utf-8?B?aU11U0NYOEFiNHR5ekw0TE1OR2l6MEZ3M3Rqc2pLQWhlYm5DVmJWRkZnWExX?= =?utf-8?B?Vkw0ZXJHQlBYRTY2VG5TWFdKSFV4K1Fqb2hUMjkvZG8xZThJaTBMOHVPNzlj?= =?utf-8?B?RDlXUnd0bnFuQ211T21Vdys0MjdwSDhOWWRNRVBwdWs4RUVFL204YVlQd0Ez?= =?utf-8?B?RWF5cll1MThtL3dRd09BdDFPbGxGeW5Fd1lIRW9mVVp1cUdMdXRvaWdWVzc2?= =?utf-8?B?S0JKTStaZDVDSVpwb2xreWtXQ2ZHdUJndmVSN1hkNmdINlhYN2p1QU9iYXph?= =?utf-8?B?dlZwU0UwMHM2aUtiOXhiQXEzOW5KRHNaSGFaaGdzWTRzdEYwS3BsVWF0Wk9n?= =?utf-8?B?QWwybk1PVGVnR3pQdE91RXFjUEVIb01JLzRrS1RJbmhhazFBbnI4NzBXUjlx?= =?utf-8?B?dmcrOU1kNjFjMDZKRDRDSDZPWWZNVnFncVZoRU5tTEVFTWFRcGl5Z3dXOUhN?= =?utf-8?B?ZEtJZGREdCs0QnBha1FQRndBbThKcGFoY0tCUUNFSFRIZVdhaFhNa2hVVC9Q?= =?utf-8?B?RkM2SU9jTU9MVE56b1JIL0VqNFFReU9MRC85WWtWUVc5WVpnY2pGSTFra3dL?= =?utf-8?B?OCt3LzBjS29KbUsvN09XYXFuM3lWNlprQnMwcVhYNVUrR1c0WlgyZTNRVGVn?= =?utf-8?B?cFdjKzdEWUJQNVpZRDJNRDNXUHJCZW1BS1hRUnByV1NnQjVVQ0dML3FnWFVy?= =?utf-8?B?L1Z3QXJ5bFpCcmlxVk5td3BnMzN1V1puZE44K2tSRWxNcC80TTlrUmNCQnZa?= =?utf-8?B?QlpQMU9UTkR1d3JQK1JnbTUvcjdieXJlZUY4c2N0dUs4bVVPVDc2akdtSVZC?= =?utf-8?B?N0ljNVRJSUcwTk0vL2NQMWY5RFdkR1J1a2NDdGlyK1JaeEswcWZPRG1BUXo1?= =?utf-8?B?TWRrS1Q1azdsc2hVOW43YXB3MDhEOTVGenJTY3ZZdFhNOUtFQVZUN2J5QWVD?= =?utf-8?B?aXEzc0VQUWs5YkhUQnhFb3dnS3NxaFN5TGoyVzQwaEsva2JhN2NmbjFVSXpJ?= =?utf-8?B?M3Y1QkhselQzMTRtOXFlaHRmSGlydnhrYjBPY001bk1tTEFsdUVoRDNDQWdl?= =?utf-8?Q?q7nLF7FS?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 6:bCxDyIijTScGIVYrIkjYLNHPL0Pi0J3eEQvSK0Pr2liHt4yeSvJ28rVib3VNMeKGSiHN7dfd/eFDDx8nDHdQmwhNyzU/r5GBIAvPCTVcL3TNNcZQpT8xO3/cO4RYSBlFTvr5qM1VZCbk/sMIbhDYjc198xAQlNfm8FQn1lJorivF94w9GKImGmbSKp2nc1ep+/1dVt/9L77lgT7LZ3rjrzl5RVBdxbybZFObrW8wOHkbIIb3NK4PNKdvGXGvyGiDpbQfdmk92QSwcXS6sOJk7kIynMnM+76KU0Cd9UB8HUVvNDhq1fNDKqczBFWYQv5jjroYZbzGVh1eXZZ0L+LlYg==; 5:MS1c6NcRPazk+Mr4eLxqlpF9uuHn9RXNKbZ/VHzDdCuJGM4RaqND1KPjd4euzW3Wlcuj5vzzttFlUax/cvR/SvUuK5JZHhDOl52JFLx3iUqjU0mDstGVvSnE3OA+MKEbnwKpeEJBzPLKOoI8Xr2iHQ==; 24:jAY76M6Dw61VRbpIVtVpTOTwqkay29W4B9AGXswSQJltZtXilqWH/80nx/LA1ipaM+sDv1lABUuFulAI48YobwXUVO6nQltt3Tke30nvljI=; 7:Iw/iyjV0LwzdFv08UaRdOYM5tpGN+G5F1GxgLC7MsryP17D2q0OtJLZHA4v/BVr9XZQaZBwHe/jz2J2kdyWnGNGqbMLGIlam1oReuivKzSNJApqH6Wq38wiwEN+JIj249tOCE9yIYOOkEYGE1e/1DAhalfJU++eiJVt/trm9n71mqwyF8IGbu/bt3nCkoWMVg5Rvc1nepclH0d20vEB2PhPVPZgI61JfZUMj9m2dDQ4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2017 13:16:45.2174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2797c6-4721-45e6-4a3e-08d51c73ce99 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0734 Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 13:16:48 -0000 On 10/26/2017 6:37 PM, Thomas Monjalon wrote: > 26/10/2017 14:59, Akhil Goyal: >> Hi Thomas, >> >> On 10/26/2017 6:03 PM, Thomas Monjalon wrote: >>> 26/10/2017 14:28, Radu Nicolau: >>>> >>>> On 10/26/2017 12:39 PM, Thomas Monjalon wrote: >>>>> 26/10/2017 13:27, David Marchand: >>>>>> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: >>>>>>> On 10/26/2017 11:36 AM, David Marchand wrote: >>>>>>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau >>>>>>>> wrote: >>>>>>>>> --- a/drivers/net/ixgbe/Makefile >>>>>>>>> +++ b/drivers/net/ixgbe/Makefile >>>>>>>>> +ifneq ($(MAKECMDGOALS),clean) >>>>>>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) >>>>>>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") >>>>>>>>> +endif >>>>>>>>> +endif >>>>>>>> This is a no go for me unless you explain how it is impossible to >>>>>>>> disable it in the code. >>>>>>>> >>>>>>>> >>>>>>> It can be disabled in the code, but as far as I know there is a general push >>>>>>> back against having conditionally compiled code. I originally had the >>>>>>> security sections in ixgbe PMD isolated, but the feedback was to have them >>>>>>> always on. >>>>>> In my mind, this was to stop having features enabled per pmd (and stop >>>>>> the nightmare with 10 options in a pmd). >>>>>> Having features globally enabled for all or nothing is still >>>>>> acceptable, is it not ? >>>>> Yes there is a config option for rte_security, >>>>> and it is acceptable. >>>>> The code depending on it must be ifdef'ed. >>>> >>>> Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I >>>> would go with Konstantin's proposal, have rte_security listed as a >>>> dependency (instead of the explicit check). >>> >>> Please consider my request instead. >>> Until now we are ifdef'ing code to allow disabling any lib. >>> We are not going to change our mind during the last days of a release. >>> Please just fix it for now. >> >> For dpaa2_sec we do not want to make the driver run without >> rte_security. We do not see people using it without rte_security. > > Why not? We see a lot of performance difference in the two cases. People may not like to see a lower performance for the same protocol processing. > >> Will take the Makefile changes that Radu has done in 1st patch of this >> series. > > Is it really a lot to ifdef? As I see it would be around 12-13 checks in 2 files. > > It is going to break compilation of DPDK for those who disable rte_security. > Well I would say, if people do not need rte_security then they can disable dpaa2_sec_pmd also. -Akhil