From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 82D2349E0 for ; Fri, 5 Oct 2018 10:13:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 01:13:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,343,1534834800"; d="scan'208";a="96684900" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.112]) ([10.252.17.112]) by orsmga001.jf.intel.com with ESMTP; 05 Oct 2018 01:13:08 -0700 To: Pawel Wodkowski , dev@dpdk.org References: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com> From: "Burakov, Anatoly" Message-ID: <2b5aab7e-85cc-eb44-7da8-1bdc7484f298@intel.com> Date: Fri, 5 Oct 2018 09:13:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 08:13:10 -0000 On 21-Sep-18 12:56 PM, Pawel Wodkowski wrote: > The final_va field is set during remap_segment() but this information is > not propagated to temporal copy of huge page memory configuration so the > unlink_hugepage_files() function wrongly assume that there is nothing to > unlink. Fix this issue by checking orig_va instead of final_va. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > To: Anatoly Burakov > > Signed-off-by: Pawel Wodkowski > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly