From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id 0A5385A44 for ; Tue, 9 May 2017 19:52:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2387; q=dns/txt; s=iport; t=1494352367; x=1495561967; h=to:from:subject:message-id:date:mime-version: content-transfer-encoding; bh=Pnz/rg88w/LRbNVENyShmL77y8LEVNOurdKT8F27Q+Y=; b=fEe7VXxuaMZ0ceGIxXLhQ54RFTjQMWu4dQ28fTy9MVbBxq3rQsQl8fd1 arhFJDyNuve9RJkKY6+ZnpXu2eHTZ8e6aryTU3Vk8YWmC4X5R23RzSfSd hewlbwqqEvZ+XX1LGSsPT6povxHANXNz1hxfpLtQeAfCHVGTou2Aw4LpW 0=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CBAgBzARJZ/51dJa1ZAxkBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYNVYoEMg2mtAYRfgg8sgh0BJIM2hG9AFwECAQEBAQEBAWsohT8?= =?us-ascii?q?EER1TBgImAmAMBgIBAYodDrMHgWw6inABAQgCASWBC4NDghFodiuCH4UFEgEoF?= =?us-ascii?q?SaCQ4JfBZ4FkxmCBIU7g0OGaUiTeCEBNX8LTyEVh1UkNgGGRYIuAQEB?= X-IronPort-AV: E=Sophos;i="5.38,315,1491264000"; d="scan'208";a="419024408" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2017 17:52:45 +0000 Received: from [10.150.214.135] ([10.150.214.135]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v49Hqjjl011339; Tue, 9 May 2017 17:52:45 GMT To: dev@dpdk.org, laurent.hardy@6wind.com From: Roger B Melton Message-ID: <2b994b06-0b9e-6e12-79b7-b5f270d0c3ee@cisco.com> Date: Tue, 9 May 2017 13:52:45 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2017 17:52:47 -0000 After updating to 17.05-rc4 I hit a crash in drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update(). The issue was a NULL get_media_type FV for the VF driver. Looking at recent commits, I see the following added the get_media_type() check: commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572 Author: Laurent Hardy Date: Thu Apr 27 17:03:42 2017 +0200 @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) hw->mac.get_link_status = true; + if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && + hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { + speed = hw->phy.autoneg_advertised; + if (!speed) + ixgbe_get_link_capabilities(hw, &speed, &autoneg); + ixgbe_setup_link(hw, speed, true); + } + This is fine for the PF driver, but we shouldn't invoke get_media_type for the VF. Laurent, Is this a bug, or am I missing something? If it is a bug, what's the proper fix? Regards, Roger -- ____________________________________________________________________ |Roger B. Melton | | Cisco Systems | |CPP Software :|: :|: 7100 Kit Creek Rd | |+1.919.476.2332 phone :|||: :|||: RTP, NC 27709-4987 | |+1.919.392.1094 fax .:|||||||:..:|||||||:. rmelton@cisco.com | | | | This email may contain confidential and privileged material for the| | sole use of the intended recipient. Any review, use, distribution | | or disclosure by others is strictly prohibited. If you are not the | | intended recipient (or authorized to receive for the recipient), | | please contact the sender by reply email and delete all copies of | | this message. | | | | For corporate legal information go to: | | http://www.cisco.com/web/about/doing_business/legal/cri/index.html | |__________________________ http://www.cisco.com ____________________|