From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jin Yu <jin.yu@intel.com>, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost-blk: delete the unused return value
Date: Tue, 26 Nov 2019 15:58:05 +0100 [thread overview]
Message-ID: <2bafbd4b-cd6c-4f80-8fb8-d69debfb1439@redhat.com> (raw)
In-Reply-To: <20191126153716.8240-1-jin.yu@intel.com>
On 11/26/19 4:37 PM, Jin Yu wrote:
> Coverity issue: 350592
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> examples/vhost_blk/vhost_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
> index 3182a488b..ff2f138b3 100644
> --- a/examples/vhost_blk/vhost_blk.c
> +++ b/examples/vhost_blk/vhost_blk.c
> @@ -852,7 +852,7 @@ new_device(int vid)
>
> if (ctrlr->packed_ring) {
> /* for the reconnection */
> - ret = rte_vhost_get_vring_base_from_inflight(
> + rte_vhost_get_vring_base_from_inflight(
> ctrlr->bdev->vid, i,
> &blk_vq->last_avail_idx,
> &blk_vq->last_used_idx);
>
It may be safer to handle the error, isn't it?
Maxime
next prev parent reply other threads:[~2019-11-26 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:37 Jin Yu
2019-11-26 14:58 ` Maxime Coquelin [this message]
2019-11-27 12:16 ` [dpdk-dev] [PATCH v2] vhost-blk: fix " Jin Yu
2019-11-27 12:57 ` Maxime Coquelin
2020-01-09 15:51 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bafbd4b-cd6c-4f80-8fb8-d69debfb1439@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).