From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C833FA0C43; Tue, 14 Sep 2021 09:29:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F51E4068F; Tue, 14 Sep 2021 09:29:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 957B34003C for ; Tue, 14 Sep 2021 09:29:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631604585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3CBeY+bh5s7PBoO0tmJGSz/73C0BSufOt+LA+8YyfDo=; b=NUIdVDaCJTn5pkRZNPBTKh+kov2XjbeDuFMRkZ/4UAFvQW8kKbE5NDBGk7Ms1Mr5tjcjN5 mxaH5W7unw312kuV6OfCzeB+w0Q6qmUmOKuwDFf8lskU29YFGPFF6llMaqydJ8Gvn4+fpN e9ZCs/0ctIqvRj/Lp2pOa3HpKXnWOWA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-44efIKMsN0G-CMRbVS9-Ow-1; Tue, 14 Sep 2021 03:29:42 -0400 X-MC-Unique: 44efIKMsN0G-CMRbVS9-Ow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87C971084686; Tue, 14 Sep 2021 07:29:41 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E4105D6A8; Tue, 14 Sep 2021 07:29:40 +0000 (UTC) To: Andrew Rybchenko , Chenbo Xia Cc: dev@dpdk.org, Ivan Ilchenko References: <20210820124812.3522838-1-andrew.rybchenko@oktetlabs.ru> <2c299708-fa0e-dc2b-0f6d-193c12add364@oktetlabs.ru> From: Maxime Coquelin Message-ID: <2bb03c5d-9793-5eca-b323-165f247d0f72@redhat.com> Date: Tue, 14 Sep 2021 09:29:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2c299708-fa0e-dc2b-0f6d-193c12add364@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/21 8:43 AM, Andrew Rybchenko wrote: > On 9/13/21 10:52 PM, Maxime Coquelin wrote: >> >> >> On 8/20/21 2:48 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Report max/min/align descriptors limits in device info get callback. >>> Before calling the callback, rte_eth_dev_info_get() provides >>> default values of nb_min as zero and nb_max as UINT16_MAX that are >>> not correct for the driver, so one can't rely on them. >>> >>> Signed-off-by: Ivan Ilchenko >>> Signed-off-by: Andrew Rybchenko >>> --- >>> drivers/net/virtio/virtio_ethdev.c | 25 +++++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>> index e58085a2c9..601c03e079 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -33,6 +33,7 @@ >>> #include "virtio_logs.h" >>> #include "virtqueue.h" >>> #include "virtio_rxtx.h" >>> +#include "virtio_rxtx_simple.h" >>> #include "virtio_user/virtio_user_dev.h" >>> >>> static int virtio_dev_configure(struct rte_eth_dev *dev); >>> @@ -2536,6 +2537,30 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >>> if ((host_features & tso_mask) == tso_mask) >>> dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; >>> >>> + if (host_features & (1ULL << VIRTIO_F_RING_PACKED)) { >>> + /* >>> + * According to 2.7 Packed Virtqueues, >>> + * 2.7.10.1 Structure Size and Alignment: >>> + * The Queue Size value does not have to be a power of 2. >>> + */ >>> + dev_info->rx_desc_lim.nb_max = UINT16_MAX; >>> + } else { >>> + /* >>> + * According to 2.6 Split Virtqueues: >>> + * Queue Size value is always a power of 2. The maximum Queue >>> + * Size value is 32768. >>> + */ >>> + dev_info->rx_desc_lim.nb_max = 32768; >>> + } >>> + /* >>> + * Actual minimum is not the same for virtqueues of different kinds, >>> + * but to avoid tangling the code with separate branches, rely on >>> + * default thresholds since desc number must be at least of their size. >>> + */ >>> + dev_info->rx_desc_lim.nb_min = RTE_MAX(DEFAULT_RX_FREE_THRESH, >>> + RTE_VIRTIO_VPMD_RX_REARM_THRESH); >>> + dev_info->rx_desc_lim.nb_align = 1; >>> + >> >> It makes sense, but shouldn't we do the same for dev_info->tx_desc_lim? > > Yes, you're right. We'll care about it. > > I suggest to add "Rx" in the summary and care about Tx in a > subsequent patch. > > net/virtio: report max/min/align Rx desc limits in dev info > > OK? > Works for me! I will fix the title while applying. Thanks, Maxime