From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC3C8A0471 for ; Mon, 9 Sep 2019 10:42:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 553C51E97D; Mon, 9 Sep 2019 10:42:23 +0200 (CEST) Received: from mx0.arrikto.com (mx0.arrikto.com [212.71.252.59]) by dpdk.org (Postfix) with ESMTP id 2A03B1E8A0 for ; Mon, 9 Sep 2019 10:42:22 +0200 (CEST) Received: from troi.prod.arr (mail.arr [10.99.0.5]) by mx0.arrikto.com (Postfix) with ESMTP id D68E3182004; Mon, 9 Sep 2019 11:42:21 +0300 (EEST) Received: from [10.89.50.133] (unknown [10.89.50.133]) by troi.prod.arr (Postfix) with ESMTPSA id 8CC9C60; Mon, 9 Sep 2019 11:42:21 +0300 (EEST) To: Maxime Coquelin , dev@dpdk.org Cc: Tiwei Bie , Zhihong Wang , Stefan Hajnoczi , Wei Wang , Stojaczyk Dariusz , Vangelis Koukis References: <1560957293-17294-1-git-send-email-ndragazis@arrikto.com> <1560957293-17294-19-git-send-email-ndragazis@arrikto.com> <4401daab-42ba-e2e4-3734-4dac4c5f6311@redhat.com> From: Nikos Dragazis Message-ID: <2bc7e274-d834-7360-1eb7-26afd39aa0c1@arrikto.com> Date: Mon, 9 Sep 2019 11:42:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <4401daab-42ba-e2e4-3734-4dac4c5f6311@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 18/28] drivers/virtio_vhost_user: add virtio PCI framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/9/19 7:34 μ.μ., Maxime Coquelin wrote: > Hi Nikos, > > On 6/19/19 5:14 PM, Nikos Dragazis wrote: >> The virtio-vhost-user transport requires a driver for the >> virtio-vhost-user PCI device, hence it needs a virtio-pci driver. There >> is currently no librte_virtio API that we can use. >> >> This commit is a hack that duplicates the virtio pci code from >> drivers/net/ into drivers/virtio_vhost_user/. A better solution would >> be to extract the code cleanly from drivers/net/ and share it. Or >> perhaps we could backport SPDK's lib/virtio/. > I think it would make sense to have a Virtio library, that could be re- > used by net, crypto and virtio-vhost-user. > > I didn't know about SPDK's lib. Maybe it is better to start from virtio- > net PMD codebase and then convert crypto and SPDK to use it. > > What do you think? > >> drivers/virtio_vhost_user/ will host the virtio-vhost-user transport >> implementation in the upcoming patches. > Thanks, > Maxime Hi Maxime, thanks for your comments. I agree with you. There is no point in having duplicated code here and there. A standalone virtio library sounds like a better approach. I will come back with a proper patchset for this purpose. Best regards, Nikos