From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A2F2A04B0; Tue, 22 Sep 2020 14:24:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BBB41DBAD; Tue, 22 Sep 2020 14:24:41 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 40AF81DB82 for ; Tue, 22 Sep 2020 14:24:39 +0200 (CEST) IronPort-SDR: y8fMvjpli8SwJEm+uFQMAhi28y9Qj6okVRn9GxX5+Z5aUlBO64xzlLEimUCWZ6HE5uxoQgyTqo +307f+LW8X/g== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148254929" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="148254929" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 05:24:38 -0700 IronPort-SDR: IUjvK8rGH+t2htdSRU9mVLh1N5IdkfMZZy9zDP5vexsLEyCSQTTIfGxSrHgGR3S3Y/OfeREKOG 8imKQrHrZhYw== X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="454476399" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.201]) ([10.213.227.201]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 05:24:36 -0700 To: Stephen Hemminger , Michal Krawczyk Cc: dev@dpdk.org, gtzalik@amazon.com, igorch@amazon.com References: <20200917053035.1889989-1-mk@semihalf.com> <20200917100202.52455f14@hermes.lan> From: Ferruh Yigit Message-ID: <2bfe634d-e9bd-4e2b-4b73-ebc4c751938f@intel.com> Date: Tue, 22 Sep 2020 13:24:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200917100202.52455f14@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2020 6:02 PM, Stephen Hemminger wrote: > On Thu, 17 Sep 2020 07:30:15 +0200 > Michal Krawczyk wrote: > >> Hi, >> >> this patchset contains upgrade of the of the HAL, which, beside some fixes, also >> adds possibility for reading ENI metrics from the device. >> >> Those are further exposed to the DPDK applicaiton using xstats. >> >> As it's an extra call to the admin queue during a PMD runtime, for multithread >> safet the locks had to be added around those functions. >> >> Michal Krawczyk (20): >> net/ena/base: use min/max macros with type conversion >> net/ena/base: specify operations of rte_delay >> net/ena/base: support 'resource busy' admin status >> net/ena/base: exponential delay in polling functions >> net/ena/base: fix release of wait event >> net/ena/base: remove MMIOWB_NOT_DEFINED ifdef >> net/ena/base: rework setup of accelerated LLQ mode >> net/ena/base: add ENI stats >> net/ena/base: split RSS function and hash getters >> net/ena/base: do not use hardcoded RSS key buffer size >> net/ena/base: check for RSS key configuration support >> net/ena/base: minor style adjustments >> net/ena/base: add missing unlikely >> net/ena/base: store admin stats as u64 >> net/ena/base: add check for meta desc being NULL >> net/ena/base: convert values to u32 before shifting >> net/ena/base: simplify loop copying Rx descs >> net/ena/base: update generation date and commit >> net/ena: lock dynamic usages of the admin queue >> net/ena: expose ENI stats as additional xstats >> >> drivers/net/ena/base/ena_com.c | 137 ++++++++++++------ >> drivers/net/ena/base/ena_com.h | 57 ++++++-- >> .../net/ena/base/ena_defs/ena_admin_defs.h | 56 ++++++- >> .../net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +- >> drivers/net/ena/base/ena_defs/ena_gen_info.h | 5 +- >> drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +- >> drivers/net/ena/base/ena_eth_com.c | 34 +++-- >> drivers/net/ena/base/ena_eth_com.h | 2 +- >> drivers/net/ena/base/ena_plat_dpdk.h | 19 ++- >> drivers/net/ena/ena_ethdev.c | 86 ++++++++++- >> drivers/net/ena/ena_ethdev.h | 34 +++++ >> 11 files changed, 344 insertions(+), 92 deletions(-) >> > > Looks good > > Reviewed-by: Stephen Hemminger > Series applied to dpdk-next-net/main, thanks.